linux-kernel - Re: [PATCH net-next v4 6/7] net: axienet: Rearrange lifetime functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250805203912.GE61519@horms.kernel.org>
Date: Tue, 5 Aug 2025 21:39:12 +0100
From: Simon Horman <horms@...nel.org>
To: Sean Anderson <sean.anderson@...ux.dev>
Cc: Radhey Shyam Pandey <radhey.shyam.pandey@....com>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S . Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Michal Simek <michal.simek@....com>,
	Leon Romanovsky <leon@...nel.org>
Subject: Re: [PATCH net-next v4 6/7] net: axienet: Rearrange lifetime
 functions

On Tue, Aug 05, 2025 at 11:34:55AM -0400, Sean Anderson wrote:
> Rearrange the lifetime functions (probe, remove, etc.) in preparation
> for the next commit. No functional change intended.
> 
> Signed-off-by: Sean Anderson <sean.anderson@...ux.dev>

...

> diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet.h b/drivers/net/ethernet/xilinx/xilinx_axienet.h

...

>  /**
>   * struct axienet_local - axienet private per device data
>   * @ndev:	Pointer for net_device to which it will be attached.
> @@ -549,6 +572,7 @@ struct skbuf_dma_descriptor {
>  struct axienet_local {
>  	struct net_device *ndev;
>  	struct device *dev;
> +	struct axienet_common *cp;

nit: Please add cp to, and remove axi_clk and regs_start from
     the Kernel doc for this structure.

     Flagged by ./scripts/kernel-doc -none

>  
>  	struct phylink *phylink;
>  	struct phylink_config phylink_config;
> @@ -558,13 +582,11 @@ struct axienet_local {
>  
>  	bool switch_x_sgmii;
>  
> -	struct clk *axi_clk;
>  	struct clk_bulk_data misc_clks[XAE_NUM_MISC_CLOCKS];
>  
>  	struct mii_bus *mii_bus;
>  	u8 mii_clk_div;
>  
> -	resource_size_t regs_start;
>  	void __iomem *regs;
>  	void __iomem *dma_regs;
>  

...