linux-kernel - Re: [PATCH net v2] net: usbnet: Fix the wrong netif_carrier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aJJ0qKopqPg38dMG@linux.gnuweeb.org>
Date: Wed, 6 Aug 2025 04:16:24 +0700
From: Ammar Faizi <ammarfaizi2@...weeb.org>
To: Linus Torvalds <torvalds@...ux-foundation.org>,
	Simon Horman <horms@...nel.org>
Cc: Oliver Neukum <oneukum@...e.com>, Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Linux Netdev Mailing List <netdev@...r.kernel.org>,
	Linux USB Mailing List <linux-usb@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Armando Budianto <sprite@...weeb.org>, gwml@...r.gnuweeb.org,
	stable@...r.kernel.org, John Ernberg <john.ernberg@...ia.se>
Subject: Re: [PATCH net v2] net: usbnet: Fix the wrong netif_carrier_on()
 call placement

On Tue, Aug 05, 2025 at 09:28:48PM +0100, Simon Horman wrote:
> It seems this has escalated a bit as it broke things for Linus while
> he was travelling. He tested this patch and it resolved the problem.
> Which I think counts for something.
> 
> https://lore.kernel.org/netdev/CAHk-=wgkvNuGCDUMMs9bW9Mz5o=LcMhcDK_b2ThO6_T7cquoEQ@mail.gmail.com/
> 
> I have looked over the patch and it appears to me that it addresses a
> straightforward logic error: a check was added to turn the carrier on only
> if it is already on. Which seems a bit nonsensical. And presumably the
> intention was to add the check for the opposite case.
> 
> This patch addresses that problem.
> 
> So let me try and nudge this on a bit by providing a tag.
> 
> Reviewed-by: Simon Horman <horms@...nel.org>

Hi Linus,

Given that Reviewed-by tag and the simplicity of the patch, it would be
great if you can take this patch sooner to your tree. The fix is very
critical for network connectivity. Especially for laptop users.

https://lore.kernel.org/all/20250801190310.58443-1-ammarfaizi2@gnuweeb.org/

-- 
Ammar Faizi