linux-kernel - Re: [PATCH net-next v4 7/7] net: axienet: Split into MAC and MDIO drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c320da3b-6e55-474a-93d6-666092b70774@lunn.ch>
Date: Tue, 5 Aug 2025 23:40:57 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Sean Anderson <sean.anderson@...ux.dev>
Cc: Radhey Shyam Pandey <radhey.shyam.pandey@....com>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S . Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Michal Simek <michal.simek@....com>,
	Leon Romanovsky <leon@...nel.org>
Subject: Re: [PATCH net-next v4 7/7] net: axienet: Split into MAC and MDIO
 drivers

> Fixes: 1a02556086fc ("net: axienet: Properly handle PCS/PMA PHY for 1000BaseX mode")

If this is for net-next, please don't have a Fixes: tag.

>  struct axienet_common {
>  	struct platform_device *pdev;
> +	struct auxiliary_device mac;
>  
>  	struct clk *axi_clk;
>  
>  	struct mutex reset_lock;
> -	struct mii_bus *mii_bus;
> +	struct auxiliary_device mii_bus;

Keeping the name mii_bus for something which is not an struct mii_bus
is going to cause confusion. Please give it a different name.

This is another patch which needs splitting up.

   Andrew