linux-kernel - Re: [RFC PATCH 2/2] tty: serial/8250: Fix build warning in serial8250_probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aJKDp1LBpzswp5lX@smile.fi.intel.com>
Date: Wed, 6 Aug 2025 01:20:23 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Abinash Singh <abinashsinghlalotra@...il.com>
Cc: gregkh@...uxfoundation.org, jirislaby@...nel.org,
	sunilvl@...tanamicro.com, arnd@...db.de,
	u.kleine-koenig@...libre.com, linux-kernel@...r.kernel.org,
	linux-serial@...r.kernel.org
Subject: Re: [RFC PATCH 2/2]  tty: serial/8250: Fix build warning in
 serial8250_probe_platform()

On Wed, Aug 06, 2025 at 01:21:55AM +0530, Abinash Singh wrote:
>     The function serial8250_probe_platform() in 8250_platform.c triggered a
>         frame size warning:
>     drivers/tty/serial/8250/8250_platform.c: In function ‘serial8250_probe_platform.isra’:
> drivers/tty/serial/8250/8250_platform.c:201:1: warning: the frame size of 1184 bytes is larger than 1024 bytes [-Wframe-larger-than=]
> 
> This patch reduces the stack usage by dynamically allocating the
> `uart` structure using kmalloc(), rather than placing it on
> the stack. This eliminates the overflow warning and improves kernel
> robustness.

Same comments as per patch 1.
Also, here in the Subject you have an extra space. Actually, check output of

git log --oneline --no-merges -- drivers/tty/serial/8250/8250_platform.c

to have a hint how the Subject should look like.

...

The approach in general is okay to me.

-- 
With Best Regards,
Andy Shevchenko