linux-kernel - Re: [PATCH v2 6/7] crypto: md5 - Wrap library and add HMAC support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250805225204.GA9931@quark>
Date: Tue, 5 Aug 2025 15:52:04 -0700
From: Eric Biggers <ebiggers@...nel.org>
To: linux-crypto@...r.kernel.org
Cc: linux-kernel@...r.kernel.org, Ard Biesheuvel <ardb@...nel.org>,
	"Jason A . Donenfeld" <Jason@...c4.com>, linux-mips@...r.kernel.org,
	linuxppc-dev@...ts.ozlabs.org, sparclinux@...r.kernel.org
Subject: Re: [PATCH v2 6/7] crypto: md5 - Wrap library and add HMAC support

On Tue, Aug 05, 2025 at 03:28:54PM -0700, Eric Biggers wrote:
> Reimplement crypto/md5.c on top of the new MD5 library functions.  Also
> add support for HMAC-MD5, again just wrapping the library functions.
> 
> This closely mirrors crypto/sha1.c.
> 
> Signed-off-by: Eric Biggers <ebiggers@...nel.org>
> ---
>  crypto/Kconfig            |   2 +-
>  crypto/md5.c              | 359 ++++++++++++++++++--------------------
>  crypto/testmgr.c          |   3 +
>  drivers/crypto/img-hash.c |   2 +-
>  4 files changed, 171 insertions(+), 195 deletions(-)
> 
> diff --git a/crypto/Kconfig b/crypto/Kconfig
> index 23bd98981ae8e..331c4fbb158b2 100644
> --- a/crypto/Kconfig
> +++ b/crypto/Kconfig
> @@ -937,11 +937,11 @@ config CRYPTO_MD4
>  
>  config CRYPTO_MD5
>  	tristate "MD5"
>  	select CRYPTO_HASH
>  	help
> -	  MD5 message digest algorithm (RFC1321)
> +	  MD5 message digest algorithm (RFC1321), including HMAC support.

Correction: there needs to be 'select CRYPTO_LIB_MD5' above.

- Eric