linux-kernel - Re: [PATCH v9 04/16] perf tp_pmu: Factor existing tracepoint logic to new file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAH0uvohOy4GzV6Cezp1NKb57sD-H=ywFN51AaZg2BnVoczrJ-w@mail.gmail.com>
Date: Tue, 5 Aug 2025 15:57:51 -0700
From: Howard Chu <howardchu95@...il.com>
To: Ian Rogers <irogers@...gle.com>
Cc: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>, 
	Arnaldo Carvalho de Melo <acme@...nel.org>, Namhyung Kim <namhyung@...nel.org>, 
	Mark Rutland <mark.rutland@....com>, 
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>, Jiri Olsa <jolsa@...nel.org>, 
	Adrian Hunter <adrian.hunter@...el.com>, Kan Liang <kan.liang@...ux.intel.com>, 
	James Clark <james.clark@...aro.org>, Xu Yang <xu.yang_2@....com>, 
	"Masami Hiramatsu (Google)" <mhiramat@...nel.org>, Collin Funk <collin.funk1@...il.com>, 
	Weilin Wang <weilin.wang@...el.com>, Andi Kleen <ak@...ux.intel.com>, 
	"Dr. David Alan Gilbert" <linux@...blig.org>, Thomas Richter <tmricht@...ux.ibm.com>, 
	Tiezhu Yang <yangtiezhu@...ngson.cn>, Gautam Menghani <gautam@...ux.ibm.com>, 
	Thomas Falcon <thomas.falcon@...el.com>, Chun-Tse Shao <ctshao@...gle.com>, 
	linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org, 
	Arnaldo Carvalho de Melo <acme@...hat.com>
Subject: Re: [PATCH v9 04/16] perf tp_pmu: Factor existing tracepoint logic to
 new file

Hello Ian,

On Fri, Jul 25, 2025 at 11:52 AM Ian Rogers <irogers@...gle.com> wrote:
>
> Start the creation of a tracepoint PMU abstraction. Tracepoint events
> don't follow the regular sysfs perf conventions. Eventually the new
> PMU abstraction will bridge the gap so tracepoint events look more
> like regular perf ones.
>
> Signed-off-by: Ian Rogers <irogers@...gle.com>
> Tested-by: Arnaldo Carvalho de Melo <acme@...hat.com>

<SNIP>

> +       while (!ret && (evt_ent = io_dir__readdir(&evt_dir))) {
> +               if (!strcmp(evt_ent->d_name, ".")
> +                   || !strcmp(evt_ent->d_name, "..")
> +                   || !strcmp(evt_ent->d_name, "enable")
> +                   || !strcmp(evt_ent->d_name, "filter"))
> +                       continue;
> +
> +               ret = cb(state, sys, evt_ent->d_name);
> +               if (ret)
> +                       break;

Don't think this breakage is needed.

> +       }
> +       close(evt_dir.dirfd);
> +       return ret;
> +}
> +
> +int tp_pmu__for_each_tp_sys(void *state, tp_sys_callback cb)
> +{
> +       struct io_dirent64 *events_ent;
> +       struct io_dir events_dir;
> +       int ret = 0;
> +       char *events_dir_path = get_tracing_file("events");
> +
> +       if (!events_dir_path)
> +               return -errno;
> +
> +       io_dir__init(&events_dir, open(events_dir_path, O_CLOEXEC | O_DIRECTORY | O_RDONLY));
> +       if (events_dir.dirfd < 0) {
> +               ret = -errno;
> +               put_events_file(events_dir_path);
> +               return ret;
> +       }
> +       put_events_file(events_dir_path);
> +
> +       while (!ret && (events_ent = io_dir__readdir(&events_dir))) {
> +               if (!strcmp(events_ent->d_name, ".") ||
> +                   !strcmp(events_ent->d_name, "..") ||
> +                   !strcmp(events_ent->d_name, "enable") ||
> +                   !strcmp(events_ent->d_name, "header_event") ||
> +                   !strcmp(events_ent->d_name, "header_page"))
> +                       continue;
> +
> +               ret = cb(state, events_ent->d_name);
> +               if (ret)
> +                       break;

Here as well.

Thanks,
Howard