[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250805234355-GYA958398@gentoo>
Date: Wed, 6 Aug 2025 07:43:55 +0800
From: Yixun Lan <dlan@...too.org>
To: Troy Mitchell <troy.mitchell@...ux.spacemit.com>
Cc: conor+dt@...nel.org, devicetree@...r.kernel.org, elder@...cstar.com,
heylenay@....org, inochiama@...look.com, krzk+dt@...nel.org,
linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-riscv@...ts.infradead.org, mturquette@...libre.com,
robh@...nel.org, sboyd@...nel.org, spacemit@...ts.linux.dev,
ziyao@...root.org
Subject: Re: [PATCH v4 2/2] clk: spacemit: fix sspax_clk
Hi Troy,
to make the title more clear and explicit, how about:
"clk: spacemit: introduce SSPAx_I2S_BCLK clock for SSPA"
On 21:16 Tue 05 Aug , Troy Mitchell wrote:
> Hardware Requirement:
> When FNCLKSEL in APBC_SSPAX_CLK_RST is set to 7 (3'b111),
..
> BIT3 must be set to 1 for the SSPAx parent clock to be I2S_BCLK.
>
> This patch introduces SSPAx_I2S_BCLK as a virtual gate to enable BIT3.
>
slightly improve the wording, and check if it's accurate:
BIT[3] of this register must be set if need to select i2s_bclk as
SSPA parent clock, to solve this, introduces a new SSPAx_I2S_BCLK
clock as the virtual gate clock.
> Suggested-by: Yao Zi <ziyao@...root.org>
> Reviewed-by: Haylen Chu <heylenay@....org>
> Signed-off-by: Troy Mitchell <troy.mitchell@...ux.spacemit.com>
> ---
> drivers/clk/spacemit/ccu-k1.c | 29 +++++++++++++++++++++++++----
> 1 file changed, 25 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/clk/spacemit/ccu-k1.c b/drivers/clk/spacemit/ccu-k1.c
> index cdde37a05235..4a91d28da2fb 100644
> --- a/drivers/clk/spacemit/ccu-k1.c
> +++ b/drivers/clk/spacemit/ccu-k1.c
> @@ -349,7 +349,14 @@ CCU_GATE_DEFINE(aib_clk, CCU_PARENT_NAME(vctcxo_24m), APBC_AIB_CLK_RST, BIT(1),
>
> CCU_GATE_DEFINE(onewire_clk, CCU_PARENT_NAME(vctcxo_24m), APBC_ONEWIRE_CLK_RST, BIT(1), 0);
>
> -static const struct clk_parent_data sspa_parents[] = {
> +/*
> + * When i2s_bclk is selected as the parent clock of sspa,
> + * the hardware requires bit3 to be set
> + */
> +CCU_GATE_DEFINE(sspa0_i2s_bclk, CCU_PARENT_HW(i2s_bclk), APBC_SSPA0_CLK_RST, BIT(3), 0);
> +CCU_GATE_DEFINE(sspa1_i2s_bclk, CCU_PARENT_HW(i2s_bclk), APBC_SSPA1_CLK_RST, BIT(3), 0);
> +
> +static const struct clk_parent_data sspa0_parents[] = {
> CCU_PARENT_HW(pll1_d384_6p4),
> CCU_PARENT_HW(pll1_d192_12p8),
> CCU_PARENT_HW(pll1_d96_25p6),
> @@ -357,10 +364,22 @@ static const struct clk_parent_data sspa_parents[] = {
> CCU_PARENT_HW(pll1_d768_3p2),
> CCU_PARENT_HW(pll1_d1536_1p6),
> CCU_PARENT_HW(pll1_d3072_0p8),
> - CCU_PARENT_HW(i2s_bclk),
> + CCU_PARENT_HW(sspa0_i2s_bclk),
> };
> -CCU_MUX_GATE_DEFINE(sspa0_clk, sspa_parents, APBC_SSPA0_CLK_RST, 4, 3, BIT(1), 0);
> -CCU_MUX_GATE_DEFINE(sspa1_clk, sspa_parents, APBC_SSPA1_CLK_RST, 4, 3, BIT(1), 0);
> +CCU_MUX_GATE_DEFINE(sspa0_clk, sspa0_parents, APBC_SSPA0_CLK_RST, 4, 3, BIT(1), 0);
> +
> +static const struct clk_parent_data sspa1_parents[] = {
> + CCU_PARENT_HW(pll1_d384_6p4),
> + CCU_PARENT_HW(pll1_d192_12p8),
> + CCU_PARENT_HW(pll1_d96_25p6),
> + CCU_PARENT_HW(pll1_d48_51p2),
> + CCU_PARENT_HW(pll1_d768_3p2),
> + CCU_PARENT_HW(pll1_d1536_1p6),
> + CCU_PARENT_HW(pll1_d3072_0p8),
> + CCU_PARENT_HW(sspa1_i2s_bclk),
> +};
> +CCU_MUX_GATE_DEFINE(sspa1_clk, sspa1_parents, APBC_SSPA1_CLK_RST, 4, 3, BIT(1), 0);
> +
> CCU_GATE_DEFINE(dro_clk, CCU_PARENT_HW(apb_clk), APBC_DRO_CLK_RST, BIT(1), 0);
> CCU_GATE_DEFINE(ir_clk, CCU_PARENT_HW(apb_clk), APBC_IR_CLK_RST, BIT(1), 0);
> CCU_GATE_DEFINE(tsen_clk, CCU_PARENT_HW(apb_clk), APBC_TSEN_CLK_RST, BIT(1), 0);
> @@ -965,6 +984,8 @@ static struct clk_hw *k1_ccu_apbc_hws[] = {
> [CLK_SSPA1_BUS] = &sspa1_bus_clk.common.hw,
> [CLK_TSEN_BUS] = &tsen_bus_clk.common.hw,
> [CLK_IPC_AP2AUD_BUS] = &ipc_ap2aud_bus_clk.common.hw,
> + [CLK_SSPA0_I2S_BCLK] = &sspa0_i2s_bclk.common.hw,
> + [CLK_SSPA1_I2S_BCLK] = &sspa1_i2s_bclk.common.hw,
> };
>
> static const struct spacemit_ccu_data k1_ccu_apbc_data = {
> --
> 2.50.0
>
--
Yixun Lan (dlan)
Powered by blists - more mailing lists