linux-kernel - Re: [PATCH net v4] ptp: prevent possible ABBA deadlock in ptp_clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250805165226.5e52e8a9@kernel.org>
Date: Tue, 5 Aug 2025 16:52:26 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: tglx@...utronix.de
Cc: Vladimir Oltean <vladimir.oltean@....com>, Jeongjun Park
 <aha310510@...il.com>, richardcochran@...il.com, andrew+netdev@...n.ch,
 davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
 yangbo.lu@....com, anna-maria@...utronix.de, frederic@...nel.org,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 syzbot+7cfb66a237c4a5fb22ad@...kaller.appspotmail.com
Subject: Re: [PATCH net v4] ptp: prevent possible ABBA deadlock in
 ptp_clock_freerun()

On Tue, 29 Jul 2025 18:48:11 +0300 Vladimir Oltean wrote:
> > +static void ptp_vclock_set_subclass(struct ptp_clock *ptp)
> > +{
> > +	lockdep_set_subclass(&ptp->clock.rwsem, PTP_LOCK_VIRTUAL);  
> 
> Just not sure whether the PTP clock should be exposing this API, or the
> POSIX clock, who actually owns the rwsem.

Hi Thomas, how do you feel about PTP setting lockdep class on the clock
rwsem? Link: https://lore.kernel.org/20250728062649.469882-1-aha310510@gmail.com