linux-kernel - Re: [PATCH 4/4] smb: client: fix mid_q_entry memleak leak with per-mid locking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9b725fd7-a9fa-4e3a-a6a3-01c222891752@huaweicloud.com>
Date: Tue, 5 Aug 2025 14:08:06 +0800
From: Wang Zhaolong <wangzhaolong@...weicloud.com>
To: Steve French <smfrench@...il.com>
Cc: pshilov@...rosoft.com, linux-cifs@...r.kernel.org,
 samba-technical@...ts.samba.org, linux-kernel@...r.kernel.org,
 chengzhihao1@...wei.com, yi.zhang@...wei.com, yangerkun@...wei.com
Subject: Re: [PATCH 4/4] smb: client: fix mid_q_entry memleak leak with
 per-mid locking

> minor sparse warning when compiling this:
> 
>    CHECK   smb2ops.c
> smb2ops.c: note: in included file:
> cifsglob.h:1362:40: error: marked inline, but without a definition
> 
> On Mon, Aug 4, 2025 at 9:00 AM Wang Zhaolong
> <wangzhaolong@...weicloud.com> wrote:

This seems to be a warning caused by the static analysis
tool analyzing the smb2ops.c file individually. The
implementation of mid_execute_callback() is actually in
connect.c, and the compiler can handle this situation
correctly.

Perhaps I should inline it directly in smb2ops.c to
eliminate the warning issue in the header file. I will
send the V2 version patch later.

Best regards,
Wang Zhaolong