linux-kernel - Re: [PATCH v4] mailbox: pcc: Add missed acpi_put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2025080552-stubbly-elliptic-6fa0@gregkh>
Date: Tue, 5 Aug 2025 08:26:08 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Markus Elfring <Markus.Elfring@....de>
Cc: Zhen Ni <zhen.ni@...ystack.cn>, linux-acpi@...r.kernel.org,
	stable@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	Jassi Brar <jassisinghbrar@...il.com>,
	Sudeep Holla <sudeep.holla@....com>
Subject: Re: [PATCH v4] mailbox: pcc: Add missed acpi_put_table() to fix
 memory leak

On Tue, Aug 05, 2025 at 08:28:17AM +0200, Markus Elfring wrote:
> > Fixes a permanent ACPI memory leak in the success path by adding
> > acpi_put_table().
> > Renaming generic 'err' label to 'put_table' for clarity.
> 
> Will a desire grow for the usage of imperative mood also in such change descriptions?
> 
> See also once more:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.16#n94
> 
> 
> …> Changes in v4:
> > - Change goto target from err to put_table.
> 
> Thanks.
> 
> 
> > - Remove goto tatget err_nomem
> …
> 
> Does this adjustment indicate questionable development difficulties?
> 
> Regards,
> Markus
> 

Hi,

This is the semi-friendly patch-bot of Greg Kroah-Hartman.

Markus, you seem to have sent a nonsensical or otherwise pointless
review comment to a patch submission on a Linux kernel developer mailing
list.  I strongly suggest that you not do this anymore.  Please do not
bother developers who are actively working to produce patches and
features with comments that, in the end, are a waste of time.

Patch submitter, please ignore Markus's suggestion; you do not need to
follow it at all.  The person/bot/AI that sent it is being ignored by
almost all Linux kernel maintainers for having a persistent pattern of
behavior of producing distracting and pointless commentary, and
inability to adapt to feedback.  Please feel free to also ignore emails
from them.

thanks,

greg k-h's patch email bot