linux-kernel - [PATCH 4/4] drm/panel: Remove goto label that are only used once

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250805074645.625911-5-liaoyuanhong@vivo.com>
Date: Tue,  5 Aug 2025 15:46:19 +0800
From: Liao Yuanhong <liaoyuanhong@...o.com>
To: Neil Armstrong <neil.armstrong@...aro.org>,
	Jessica Zhang <quic_jesszhan@...cinc.com>,
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
	Maxime Ripard <mripard@...nel.org>,
	Thomas Zimmermann <tzimmermann@...e.de>,
	David Airlie <airlied@...il.com>,
	Simona Vetter <simona@...ll.ch>,
	dri-devel@...ts.freedesktop.org (open list:DRM PANEL DRIVERS),
	linux-kernel@...r.kernel.org (open list)
Cc: Liao Yuanhong <liaoyuanhong@...o.com>
Subject: [PATCH 4/4] drm/panel: Remove goto label that are only used once

Remove unnecessary goto labels to improve code readability. 

Signed-off-by: Liao Yuanhong <liaoyuanhong@...o.com>
---
 drivers/gpu/drm/panel/panel-innolux-ej030na.c    | 7 ++-----
 drivers/gpu/drm/panel/panel-orisetech-ota5601a.c | 7 ++-----
 2 files changed, 4 insertions(+), 10 deletions(-)

diff --git a/drivers/gpu/drm/panel/panel-innolux-ej030na.c b/drivers/gpu/drm/panel/panel-innolux-ej030na.c
index f85b7a4cbb42..6779a584bbd8 100644
--- a/drivers/gpu/drm/panel/panel-innolux-ej030na.c
+++ b/drivers/gpu/drm/panel/panel-innolux-ej030na.c
@@ -105,14 +105,11 @@ static int ej030na_prepare(struct drm_panel *panel)
 				     ARRAY_SIZE(ej030na_init_sequence));
 	if (err) {
 		dev_err(dev, "Failed to init registers: %d\n", err);
-		goto err_disable_regulator;
+		regulator_disable(priv->supply);
+		return err;
 	}
 
 	return 0;
-
-err_disable_regulator:
-	regulator_disable(priv->supply);
-	return err;
 }
 
 static int ej030na_unprepare(struct drm_panel *panel)
diff --git a/drivers/gpu/drm/panel/panel-orisetech-ota5601a.c b/drivers/gpu/drm/panel/panel-orisetech-ota5601a.c
index fc87f61d4400..95cf8f36dd09 100644
--- a/drivers/gpu/drm/panel/panel-orisetech-ota5601a.c
+++ b/drivers/gpu/drm/panel/panel-orisetech-ota5601a.c
@@ -130,16 +130,13 @@ static int ota5601a_prepare(struct drm_panel *drm_panel)
 				     ARRAY_SIZE(ota5601a_panel_regs));
 	if (err) {
 		dev_err(drm_panel->dev, "Failed to init registers: %d\n", err);
-		goto err_disable_regulator;
+		regulator_disable(panel->supply);
+		return err;
 	}
 
 	msleep(120);
 
 	return 0;
-
-err_disable_regulator:
-	regulator_disable(panel->supply);
-	return err;
 }
 
 static int ota5601a_unprepare(struct drm_panel *drm_panel)
-- 
2.34.1