linux-kernel - Re: [PATCH next] PCI: xgene-msi: Return negative -EINVAL in xgene_msi_handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <86ms8e6wab.wl-maz@kernel.org>
Date: Tue, 05 Aug 2025 08:51:40 +0100
From: Marc Zyngier <maz@...nel.org>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Toan Le <toan@...amperecomputing.com>,	Lorenzo Pieralisi
 <lpieralisi@...nel.org>,	Krzysztof Wilczyński
 <kwilczynski@...nel.org>,	Manivannan Sadhasivam <mani@...nel.org>,	Rob
 Herring <robh@...nel.org>,	Bjorn Helgaas <bhelgaas@...gle.com>,
	linux-pci@...r.kernel.org,	linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org,	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH next] PCI: xgene-msi: Return negative -EINVAL in xgene_msi_handler_setup()

On Fri, 01 Aug 2025 14:34:37 +0100,
Dan Carpenter <dan.carpenter@...aro.org> wrote:
> 
> There is a typo so we accidentally return positive EINVAL instead of
> negative -EINVAL.  Add the missing '-' character.
> 
> Fixes: 6aceb36f17ab ("PCI: xgene-msi: Restructure handler setup/teardown")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> ---
>  drivers/pci/controller/pci-xgene-msi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/controller/pci-xgene-msi.c b/drivers/pci/controller/pci-xgene-msi.c
> index 0a37a3f1809c..654639bccd10 100644
> --- a/drivers/pci/controller/pci-xgene-msi.c
> +++ b/drivers/pci/controller/pci-xgene-msi.c
> @@ -311,7 +311,7 @@ static int xgene_msi_handler_setup(struct platform_device *pdev)
>  		msi_val = xgene_msi_int_read(xgene_msi, i);
>  		if (msi_val) {
>  			dev_err(&pdev->dev, "Failed to clear spurious IRQ\n");
> -			return EINVAL;
> +			return -EINVAL;
>  		}
>  
>  		irq = platform_get_irq(pdev, i);

Acked-by: Marc Zyngier <maz@...nel.org>

	M.

-- 
Without deviation from the norm, progress is not possible.