[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <e63913df-6808-4822-a3a4-870b650f10d9@uclouvain.be>
Date: Tue, 5 Aug 2025 10:23:14 +0200
From: Thomas Antoine <t.antoine@...ouvain.be>
To: Krzysztof Kozlowski <krzk@...nel.org>, Sebastian Reichel
<sre@...nel.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
<conor+dt@...nel.org>, Dimitri Fedrau <dima.fedrau@...il.com>,
Catalin Marinas <catalin.marinas@....com>, Will Deacon <will@...nel.org>,
Peter Griffin <peter.griffin@...aro.org>,
André Draszik <andre.draszik@...aro.org>,
Tudor Ambarus <tudor.ambarus@...aro.org>,
Alim Akhtar <alim.akhtar@...sung.com>
Cc: linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-samsung-soc@...r.kernel.org
Subject: Re: [PATCH v5 0/4] gs101: MAX77759 Fuel Gauge driver support and
enablement
Hello,
On 8/5/25 8:20 AM, Krzysztof Kozlowski wrote:
> On 04/08/2025 16:26, Thomas Antoine via B4 Relay wrote:
>> The gs101-oriole (Google Pixel 6) and gs101-raven (Google Pixel 6 Pro)
>> have a Maxim MAX77759 which provides a fuel gauge functionnality based
>> on the MAX M5 fuel gauge.
>>
>> Add a driver for fuel gauge of the the Maxim MAX77759 based on the
>> one for the Maxim MAX1720x which also uses the MAX M5 fuel gauge.
>> Enable it for the gs101-oriole and gs101-raven boards.
>>
>> Signed-off-by: Thomas Antoine <t.antoine@...ouvain.be>
>> ---
>> Hi everyone,
>> I decided to completely separate the MAX77759 and the MAX1720x. The
>> reason I had just modified the MAX1720x initially was because I
>> thought at the time that their difference were much less important
>> than they ended up being.
>>
>> Their common parts could be put in a common MAX M5 files which could
>> prove useful if more chips using the MAX M5 are to be added.
>>
>> Changes in v5:
>> - Separate MAX77759 from MAX1720x for clarity
>> - Remove voltage reporting
>> - Add initialization of the chip
>> - Add device dependent initialization data
>> - Add access to eeprom for access to non-volatile backup data.
>> - Link to v4: https://lore.kernel.org/r/20250523-b4-gs101_max77759_fg-v4-0-b49904e35a34@uclouvain.be
>
> No changes in the bindings? There were errors posted due to lack of testing.
The binding has changed a lot due to it being separated from
the MAX17201 binding. I tested the new binding and found no error and no
bot was triggered as far as I know. Sorry if the changes were unclear.
> Best regards,
> Krzysztof
Best regards,
Thomas
Powered by blists - more mailing lists