linux-kernel - Re: [PATCH v8 2/7] media: venus: Define minimum valid firmware version

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a5c292ec-e59b-49f0-9681-a990128cbdfe@linaro.org>
Date: Tue, 5 Aug 2025 09:29:55 +0100
From: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
To: Jorge Ramirez-Ortiz <jorge.ramirez@....qualcomm.com>,
 quic_dikshita@...cinc.com, quic_vgarodia@...cinc.com,
 konradybcio@...nel.org, krzk+dt@...nel.org
Cc: mchehab@...nel.org, conor+dt@...nel.org, andersson@...nel.org,
 linux-media@...r.kernel.org, linux-arm-msm@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v8 2/7] media: venus: Define minimum valid firmware
 version

On 05/08/2025 07:44, Jorge Ramirez-Ortiz wrote:
> +	if (!is_fw_rev_or_newer(core, ver->major, ver->minor, ver->rev))
> +		return -EINVAL;
> +

This is the sort of error case that deserves a kernel log.

dev_err(dev, "Firmware version %d.%d < minimum version %d.%d\n, etc);

If I were to try booting venus with an old/unsupported I wouldn't know 
why the probe was failing.

---
bod