linux-kernel - Re: [PATCH v?] f2fs: fix to return -EOPNOTSUPP for uncached write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d60910fc-a327-4ebc-ac24-42a668ac1402@web.de>
Date: Tue, 5 Aug 2025 11:16:38 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Chao Yu <chao@...nel.org>, linux-f2fs-devel@...ts.sourceforge.net,
 Jaegeuk Kim <jaegeuk@...nel.org>
Cc: LKML <linux-kernel@...r.kernel.org>, Jens Axboe <axboe@...nel.dk>,
 Qi Han <hanqi@...o.com>
Subject: Re: [PATCH v?] f2fs: fix to return -EOPNOTSUPP for uncached write

> f2fs doesn't support uncached write yet, for write() w/ IOCB_DONTCACHE
> flag, let's return -EOPNOTSUPP instead of ignoring IOCB_DONTCACHE flag
> and write w/o uncached IO.

See also once more:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.16#n94


…
> ---
> v2:
…

Should a corresponding information appear in the patch subject?


…
> +++ b/fs/f2fs/file.c
> @@ -5185,6 +5185,11 @@ static ssize_t f2fs_file_write_iter(struct kiocb *iocb, struct iov_iter *from)
>  		goto out;
>  	}
>  
> +	if (iocb->ki_flags & IOCB_DONTCACHE) {
> +		ret = -EOPNOTSUPP;
> +		goto out;
> +	}
> +
>  	if (!f2fs_is_compress_backend_ready(inode)) {
>  		ret = -EOPNOTSUPP;
>  		goto out;

Can it be avoided to specify duplicate exception handling?
May the condition checks be merged for these if statements?

Regards,
Markus