| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <pndbjoum7td.a.out@axis.com> Date: Tue, 5 Aug 2025 11:33:34 +0200 From: Waqar Hameed <waqar.hameed@...s.com> To: Dmitry Torokhov <dmitry.torokhov@...il.com> CC: <kernel@...s.com>, <linux-input@...r.kernel.org>, <linux-kernel@...r.kernel.org> Subject: [PATCH v2] input: zforce_ts: Remove error print for devm_add_action_or_reset() When `devm_add_action_or_reset()` fails, it is due to a failed memory allocation and will thus return `-ENOMEM`. `dev_err_probe()` doesn't do anything when error is `-ENOMEM`. Therefore, remove the useless call to `dev_err_probe()` when `devm_add_action_or_reset()` fails, and just return the value instead. Signed-off-by: Waqar Hameed <waqar.hameed@...s.com> --- Changes in v2: * Split the patch to one seperate patch for each sub-system. Link to v1: https://lore.kernel.org/all/pnd7c0s6ji2.fsf@axis.com/ drivers/input/touchscreen/zforce_ts.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/input/touchscreen/zforce_ts.c b/drivers/input/touchscreen/zforce_ts.c index df42fdf36ae3..4d000b5b3ae6 100644 --- a/drivers/input/touchscreen/zforce_ts.c +++ b/drivers/input/touchscreen/zforce_ts.c @@ -739,8 +739,7 @@ static int zforce_probe(struct i2c_client *client) error = devm_add_action_or_reset(&client->dev, zforce_reset, ts); if (error) - return dev_err_probe(&client->dev, error, - "failed to register reset action\n"); + return error; snprintf(ts->phys, sizeof(ts->phys), "%s/input0", dev_name(&client->dev)); base-commit: 260f6f4fda93c8485c8037865c941b42b9cba5d2 -- 2.39.5
Powered by blists - more mailing lists