[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <pndwm7ikt8v.a.out@axis.com>
Date: Tue, 5 Aug 2025 11:33:36 +0200
From: Waqar Hameed <waqar.hameed@...s.com>
To: Uwe Kleine-König <ukleinek@...nel.org>, Neil Armstrong
<neil.armstrong@...aro.org>, Kevin Hilman <khilman@...libre.com>, "Jerome
Brunet" <jbrunet@...libre.com>, Martin Blumenstingl
<martin.blumenstingl@...glemail.com>
CC: <kernel@...s.com>, <linux-pwm@...r.kernel.org>,
<linux-arm-kernel@...ts.infradead.org>, <linux-amlogic@...ts.infradead.org>,
<linux-kernel@...r.kernel.org>
Subject: [PATCH v2] pwm: meson: Remove error print for
devm_add_action_or_reset()
When `devm_add_action_or_reset()` fails, it is due to a failed memory
allocation and will thus return `-ENOMEM`. `dev_err_probe()` doesn't do
anything when error is `-ENOMEM`. Therefore, remove the useless call to
`dev_err_probe()` when `devm_add_action_or_reset()` fails, and just
return the value instead.
Signed-off-by: Waqar Hameed <waqar.hameed@...s.com>
---
Changes in v2:
* Split the patch to one seperate patch for each sub-system.
Link to v1: https://lore.kernel.org/all/pnd7c0s6ji2.fsf@axis.com/
drivers/pwm/pwm-meson.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/pwm/pwm-meson.c b/drivers/pwm/pwm-meson.c
index 8c6bf3d49753..e90d37d4f956 100644
--- a/drivers/pwm/pwm-meson.c
+++ b/drivers/pwm/pwm-meson.c
@@ -520,8 +520,7 @@ static int meson_pwm_init_channels_s4(struct pwm_chip *chip)
ret = devm_add_action_or_reset(dev, meson_pwm_s4_put_clk,
meson->channels[i].clk);
if (ret)
- return dev_err_probe(dev, ret,
- "Failed to add clk_put action\n");
+ return ret;
}
return 0;
base-commit: 260f6f4fda93c8485c8037865c941b42b9cba5d2
--
2.39.5
Powered by blists - more mailing lists