linux-kernel - Re: [PATCH v2 0/8] staging: rtl8723bs: get rid of os_dep/mlme

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <23e31686-3bc2-4524-9735-fd50c1f9746e@kernel.org>
Date: Tue, 5 Aug 2025 13:02:44 +0200
From: Hans de Goede <hansg@...nel.org>
To: Michael Straube <straube.linux@...il.com>, gregkh@...uxfoundation.org
Cc: hdegoede@...hat.com, Larry.Finger@...inger.net,
 linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/8] staging: rtl8723bs: get rid of os_dep/mlme_linux.c

Hi Michael,

On 1-Aug-25 10:31 AM, Michael Straube wrote:
> This series moves/merges the functions/functionality of os_dep/mlme_linux.c
> into the corresponding parts of the driver in the core directory to reduce
> "os dependent" code.
> 
> The patches have been compile-tested only due to lack of hardware.
> 
> v1 -> v2: added back accidently removed tabs in patch 3/8
> 
> Michael Straube (8):
>   staging: rtl8723bs: remove wrapper rtw_os_indicate_scan_done
>   staging: rtl8723bs: move init_mlme_ext_timer to core/rtw_mlme_ext.c
>   staging: rtl8723bs: move rtw_init_mlme_timer to core/rtw_mlme.c
>   staging: rtl8723bs: remove wrapper init_addba_retry_timer
>   staging: rtl8723bs: merge rtw_os_indicate_connect into
>     rtw_indicate_connect
>   staging: rtl8723bs: merge rtw_os_indicate_disconnect into
>     rtw_indicate_disconnect
>   staging: rtl8723bs: move rtw_report_sec_ie to core/rtw_mlme.c
>   staging: rtl8723bs: move rtw_reset_securitypriv to core/rtw_mlme.c

Thank you for your continued work on improving the rtl8723bs driver.

I've given these patches a test-spin on a tablet with
a rtl8723bs wifi module (on top of your previous patches).

The patches work and they look good to me:

Tested-by: Hans de Goede <hansg@...nel.org>
Reviewed-by: Hans de Goede <hansg@...nel.org>

for the series.

Regards,

Hans