linux-kernel - Re: [PATCH v3 0/2] perf/s390: Regression: Move uid filtering to BPF filters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ad5dda3a-0398-45d3-8f10-ef0097604fee@linux.ibm.com>
Date: Tue, 5 Aug 2025 15:33:32 +0200
From: Thomas Richter <tmricht@...ux.ibm.com>
To: Ilya Leoshkevich <iii@...ux.ibm.com>, Alexei Starovoitov
 <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>, Ian Rogers <irogers@...gle.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>
Cc: bpf@...r.kernel.org, linux-perf-users@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-s390@...r.kernel.org,
        Jiri Olsa <jolsa@...nel.org>, Heiko Carstens <hca@...ux.ibm.com>,
        Vasily Gorbik <gor@...ux.ibm.com>,
        Alexander Gordeev <agordeev@...ux.ibm.com>
Subject: Re: [PATCH v3 0/2] perf/s390: Regression: Move uid filtering to BPF
 filters

On 8/5/25 14:54, Ilya Leoshkevich wrote:
> v2: https://lore.kernel.org/bpf/20250728144340.711196-1-tmricht@linux.ibm.com/
> v2 -> v3: Use no_ioctl_enable in perf.
> 
> v1: https://lore.kernel.org/bpf/20250725093405.3629253-1-tmricht@linux.ibm.com/
> v1 -> v2: Introduce no_ioctl_enable (Jiri).
> 
> Hi,
> 
> This series fixes a regression caused by moving UID filtering to BPF.
> The regression affects all events that support auxiliary data, most
> notably, "cycles" events on s390, but also PT events on Intel. The
> symptom is missing events when UID filtering is enabled.
> 
> Patch 1 introduces a new option for the
> bpf_program__attach_perf_event_opts() function.
> Ppatch 2 makes use of it in perf, and also contains a lot of technical

Typo Patch

> details of why exactly the prolblem is occurring.

Typo problem

> 
> Thanks to Thomas Richter for the investigation and the initial version
> of this fix, and to Jiri Olsa for suggestions.
> 
> Best regards,
> Ilya
> 
> Ilya Leoshkevich (2):
>   libbpf: Add the ability to suppress perf event enablement
>   perf bpf-filter: Enable events manually
> 
>  tools/lib/bpf/libbpf.c       | 13 ++++++++-----
>  tools/lib/bpf/libbpf.h       |  4 +++-
>  tools/perf/util/bpf-filter.c |  5 ++++-
>  3 files changed, 15 insertions(+), 7 deletions(-)
> 

Thanks for taking over!!!
For the whole series

Tested-by: Thomas Richter <tmricht@...ux.ibm.com>

-- 
Thomas Richter, Dept 3303, IBM s390 Linux Development, Boeblingen, Germany
--
IBM Deutschland Research & Development GmbH

Vorsitzender des Aufsichtsrats: Wolfgang Wendt

Geschäftsführung: David Faller

Sitz der Gesellschaft: Böblingen / Registergericht: Amtsgericht Stuttgart, HRB 243294