linux-kernel - Re: [PATCH v2 2/2] KVM: s390: Fix FOLL_*/FAULT_FLAG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250805142030.61286-A-seiden@linux.ibm.com>
Date: Tue, 5 Aug 2025 16:20:30 +0200
From: Steffen Eiden <seiden@...ux.ibm.com>
To: Claudio Imbrenda <imbrenda@...ux.ibm.com>
Cc: linux-kernel@...r.kernel.org, linux-s390@...r.kernel.org,
        kvm@...r.kernel.org, david@...hat.com, frankja@...ux.ibm.com,
        nsg@...ux.ibm.com, nrb@...ux.ibm.com, schlameuss@...ux.ibm.com,
        hca@...ux.ibm.com, mhartmay@...ux.ibm.com, borntraeger@...ibm.com
Subject: Re: [PATCH v2 2/2] KVM: s390: Fix FOLL_*/FAULT_FLAG_* confusion

On Tue, Aug 05, 2025 at 04:17:46PM +0200, Claudio Imbrenda wrote:
> Pass the right type of flag to vcpu_dat_fault_handler(); it expects a
> FOLL_* flag (in particular FOLL_WRITE), but FAULT_FLAG_WRITE is passed
> instead.
> 
> This still works because they happen to have the same integer value,
> but it's a mistake, thus the fix.
> 
> Signed-off-by: Claudio Imbrenda <imbrenda@...ux.ibm.com>
> Fixes: 05066cafa925 ("s390/mm/fault: Handle guest-related program interrupts in KVM")
> Acked-by: Christian Borntraeger <borntraeger@...ux.ibm.com>
> Reviewed-by: David Hildenbrand <david@...hat.com>

Reviewed-by: Steffen Eiden <seiden@...ux.ibm.com>