[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <47cf42a2-bc8e-4ed8-8619-79975b95230f@lunn.ch>
Date: Tue, 5 Aug 2025 17:31:53 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Ivan Vecera <ivecera@...hat.com>
Cc: Krzysztof Kozlowski <krzk@...nel.org>, netdev@...r.kernel.org,
Vadim Fedorenko <vadim.fedorenko@...ux.dev>,
Arkadiusz Kubalewski <arkadiusz.kubalewski@...el.com>,
Jiri Pirko <jiri@...nulli.us>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
Prathosh Satish <Prathosh.Satish@...rochip.com>,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
Michal Schmidt <mschmidt@...hat.com>, Petr Oros <poros@...hat.com>
Subject: Re: [PATCH net-next 1/2] dt-bindings: dpll: Add clock ID property
> Like this?
>
> diff --git a/Documentation/devicetree/bindings/dpll/dpll-device.yaml
> b/Documentation/devicetree/bindings/dpll/dpll-device.yaml
> index fb8d7a9a3693f..798c5484657cf 100644
> --- a/Documentation/devicetree/bindings/dpll/dpll-device.yaml
> +++ b/Documentation/devicetree/bindings/dpll/dpll-device.yaml
> @@ -27,11 +27,41 @@ properties:
> "#size-cells":
> const: 0
>
> - dpll-types:
> - description: List of DPLL channel types, one per DPLL instance.
> - $ref: /schemas/types.yaml#/definitions/non-unique-string-array
> - items:
> - enum: [pps, eec]
> + channels:
> + type: object
> + description: DPLL channels
> + unevaluatedProperties: false
> +
> + properties:
> + "#address-cells":
> + const: 1
> + "#size-cells":
> + const: 0
> +
> + patternProperties:
> + "^channel@[0-9a-f]+$":
> + type: object
> + description: DPLL channel
> + unevaluatedProperties: false
> +
> + properties:
> + reg:
> + description: Hardware index of the DPLL channel
> + maxItems: 1
> +
> + dpll-type:
> + description: DPLL channel type
> + $ref: /schemas/types.yaml#/definitions/string
> + enum: [pps, eec]
> +
> + ethernet-handle:
> + description:
> + Specifies a reference to a node representing an Ethernet
> device
> + that uses this channel to synchronize its hardware clock.
> + $ref: /schemas/types.yaml#/definitions/phandle
> +
> + required:
> + - reg
Yes, but i will leave the DT Maintainers to give it a deeper review,
but this what i meant. And it makes your dpll-type much easier to
handle.
Andrew
Powered by blists - more mailing lists