linux-kernel - Re: [PATCH v7 05/30] KVM: selftests: Update kvm_init_vm_address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <68922612d9712_1923952949e@iweiny-mobl.notmuch>
Date: Tue, 5 Aug 2025 10:41:06 -0500
From: Ira Weiny <ira.weiny@...el.com>
To: Sagi Shahar <sagis@...gle.com>, Ira Weiny <ira.weiny@...el.com>
CC: <linux-kselftest@...r.kernel.org>, Paolo Bonzini <pbonzini@...hat.com>,
	Shuah Khan <shuah@...nel.org>, Sean Christopherson <seanjc@...gle.com>,
	Ackerley Tng <ackerleytng@...gle.com>, Ryan Afranji <afranji@...gle.com>,
	Andrew Jones <ajones@...tanamicro.com>, Isaku Yamahata
	<isaku.yamahata@...el.com>, Erdem Aktas <erdemaktas@...gle.com>, "Rick
 Edgecombe" <rick.p.edgecombe@...el.com>, Roger Wang <runanwang@...gle.com>,
	Binbin Wu <binbin.wu@...ux.intel.com>, Oliver Upton <oliver.upton@...ux.dev>,
	"Pratik R. Sampat" <pratikrajesh.sampat@....com>, Reinette Chatre
	<reinette.chatre@...el.com>, <linux-kernel@...r.kernel.org>,
	<kvm@...r.kernel.org>, Adrian Hunter <adrian.hunter@...el.com>
Subject: Re: [PATCH v7 05/30] KVM: selftests: Update
 kvm_init_vm_address_properties() for TDX

Sagi Shahar wrote:
> On Mon, Jul 21, 2025 at 4:51 PM Ira Weiny <ira.weiny@...el.com> wrote:
> >
> > On Fri, Jun 13, 2025 at 12:13:32PM -0700, Sagi Shahar wrote:
> > > From: Isaku Yamahata <isaku.yamahata@...el.com>
> > >
> >
> > [snip]
> >
> > >
> > > diff --git a/tools/testing/selftests/kvm/lib/x86/processor.c b/tools/testing/selftests/kvm/lib/x86/processor.c
> > > index d082d429e127..d9f4ecd6ffbc 100644
> > > --- a/tools/testing/selftests/kvm/lib/x86/processor.c
> > > +++ b/tools/testing/selftests/kvm/lib/x86/processor.c
> > > @@ -1166,10 +1166,19 @@ void kvm_get_cpu_address_width(unsigned int *pa_bits, unsigned int *va_bits)
> > >
> > >  void kvm_init_vm_address_properties(struct kvm_vm *vm)
> > >  {
> > > +     uint32_t gpa_bits = kvm_cpu_property(X86_PROPERTY_GUEST_MAX_PHY_ADDR)
> >
> > This fails to compile.
> 
> Looks like it's a simple case of missing semicolon at the end of the
> line, it builds fine if you add it.

Yea.

> I can update it in the next
> version.

When do you expect this to be updated?

It would be nice to see this land soon such that we don't have to keep
carrying these patches out of tree.

Would it help if I review this series?  I thought it was relatively well
reviewed.  But given the above simple mistake perhaps it needs more
review?

Ira