linux-kernel - [PATCH] [v2] irqchip: build IMX_MU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250805160952.4006075-1-arnd@kernel.org>
Date: Tue,  5 Aug 2025 18:09:49 +0200
From: Arnd Bergmann <arnd@...nel.org>
To: Thomas Gleixner <tglx@...utronix.de>,
	Marc Zyngier <maz@...nel.org>,
	Frank Li <Frank.Li@....com>
Cc: Arnd Bergmann <arnd@...db.de>,
	Nam Cao <namcao@...utronix.de>,
	Lorenzo Pieralisi <lpieralisi@...nel.org>,
	Nicolas Frayer <nfrayer@...libre.com>,
	Geert Uytterhoeven <geert+renesas@...der.be>,
	Stanimir Varbanov <svarbanov@...e.de>,
	Inochi Amaoto <inochiama@...il.com>,
	Chen Wang <unicorn_wang@...look.com>,
	Lukas Bulwahn <lukas.bulwahn@...hat.com>,
	Vladimir Kondratiev <vladimir.kondratiev@...ileye.com>,
	Peter Robinson <pbrobinson@...il.com>,
	linux-kernel@...r.kernel.org
Subject: [PATCH] [v2] irqchip: build IMX_MU_MSI only on ARM

From: Arnd Bergmann <arnd@...db.de>

compile-testing IMX_MU_MSI on x86 without PCI_MSI support results
in a build failure:

drivers/gpio/gpio-sprd.c:8:
include/linux/gpio/driver.h:41:33: error: field 'msiinfo' has incomplete type
drivers/iommu/iommufd/viommu.c:4:
include/linux/msi.h:528:33: error: field 'alloc_info' has incomplete type

Tighten the dependency further to only allow compile testing on Arm.
This could be refined further to allow certain x86 configs.

I submitted this patch before to address a different build failure, which
was fixed independently but has now returned.

Link: https://lore.kernel.org/all/20221215164109.761427-1-arnd@kernel.org/
Fixes: 70afdab904d2d1e6 ("irqchip: Add IMX MU MSI controller driver")
Signed-off-by: Arnd Bergmann <arnd@...db.de>
---

It seems to be a recurring problem wiht x86 not using CONFIG_GENERIC_MSI_IRQ,
while all other architectures do. I wonder if that is something that
should be changed by changing the x86 irqchip implementation so that
CONFIG_GENERIC_MSI_IRQ can become the only way to do MSI.
---
 drivers/irqchip/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
index 96cca93714ef..b0b7143cae2d 100644
--- a/drivers/irqchip/Kconfig
+++ b/drivers/irqchip/Kconfig
@@ -558,6 +558,7 @@ config IMX_MU_MSI
 	tristate "i.MX MU used as MSI controller"
 	depends on OF && HAS_IOMEM
 	depends on ARCH_MXC || COMPILE_TEST
+	depends on ARM || ARM64
 	default m if ARCH_MXC
 	select IRQ_DOMAIN
 	select IRQ_DOMAIN_HIERARCHY
-- 
2.39.5