linux-kernel - Re: [PATCH v2] mfd: macsmc: Remove error prints for devm_add_action_or

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fab1f878-f174-4b21-985c-abd2e6369847@kernel.org>
Date: Wed, 6 Aug 2025 20:49:48 +0200
From: Sven Peter <sven@...nel.org>
To: Waqar Hameed <waqar.hameed@...s.com>, Janne Grunau <j@...nau.net>,
 Alyssa Rosenzweig <alyssa@...enzweig.io>, Neal Gompa <neal@...pa.dev>,
 Lee Jones <lee@...nel.org>
Cc: kernel@...s.com, asahi@...ts.linux.dev,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] mfd: macsmc: Remove error prints for
 devm_add_action_or_reset()

On 05.08.25 11:33, Waqar Hameed wrote:
> When `devm_add_action_or_reset()` fails, it is due to a failed memory
> allocation and will thus return `-ENOMEM`. `dev_err_probe()` doesn't do
> anything when error is `-ENOMEM`. Therefore, remove the useless call to
> `dev_err_probe()` when `devm_add_action_or_reset()` fails, and just
> return the value instead.
> 
> Signed-off-by: Waqar Hameed <waqar.hameed@...s.com>
> ---

Reviewed-by: Sven Peter <sven@...nel.org>


Thanks,

Sven