linux-kernel - Re: [PATCH v3 1/2] fscontext: do not consume log entries when returning -EMSGSIZE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250806190751.GG222315@ZenIV>
Date: Wed, 6 Aug 2025 20:07:51 +0100
From: Al Viro <viro@...iv.linux.org.uk>
To: Aleksa Sarai <cyphar@...har.com>
Cc: Christian Brauner <brauner@...nel.org>, Jan Kara <jack@...e.cz>,
	David Howells <dhowells@...hat.com>, Shuah Khan <shuah@...nel.org>,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-kselftest@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH v3 1/2] fscontext: do not consume log entries when
 returning -EMSGSIZE

On Thu, Aug 07, 2025 at 03:55:23AM +1000, Aleksa Sarai wrote:

> -		goto err_free;
> -	ret = -EFAULT;
> -	if (copy_to_user(_buf, p, n) != 0)
> -		goto err_free;
> +	if (copy_to_user(_buf, p, n))
> +		n = -EFAULT;
>  	ret = n;
> -
> -err_free:
>  	if (need_free)
>  		kfree(p);
>  	return ret;

Minor nit: seeing that there's only one path to that return, I would
rather turn it into
	return n;
and dropped the assignment to ret a few lines above.  Anyway, that's
trivially done when applying...

Anyway, who's carrying fscontext-related stuff this cycle?  I've got
a short series in that area, but there won't be much from me around
there - a plenty of tree-in-dcache stuff, quite a bit of mount-related
work, etc., but not a lot around the options-parsing machinery.

Christian, do you have any plans around that area?