linux-kernel - Re: [PATCH v2 1/1] mm: Correct misleading comment on mmap_lock field in mm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ab2f8752-6bac-43c6-b889-f5940a6c94af@redhat.com>
Date: Wed, 6 Aug 2025 22:06:45 +0200
From: David Hildenbrand <david@...hat.com>
To: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>,
 "Adrian Huang (Lenovo)" <adrianhuang0701@...il.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>, Liam.Howlett@...cle.com,
 Vlastimil Babka <vbabka@...e.cz>, Mike Rapoport <rppt@...nel.org>,
 Suren Baghdasaryan <surenb@...gle.com>, Michal Hocko <mhocko@...e.com>,
 Feng Tang <feng.79.tang@...il.com>, ahuang12@...ovo.com, linux-mm@...ck.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/1] mm: Correct misleading comment on mmap_lock field
 in mm_struct

On 06.08.25 21:07, Lorenzo Stoakes wrote:
> On Wed, Aug 06, 2025 at 10:59:06PM +0800, Adrian Huang (Lenovo) wrote:
>> The comment previously described the offset of mmap_lock as 0x120 (hex),
>> which is misleading. The correct offset is 56 bytes (decimal) from the
>> last cache line boundary. Using '0x120' could confuse readers trying to
>> understand why the count and owner fields reside in separate cachelines.
>>
>> This change also removes an unnecessary space for improved formatting.
>>
>> Signed-off-by: Adrian Huang (Lenovo) <adrianhuang0701@...il.com>
> 
> LGTM, so:
> 
> Reviewed-by: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>

Acked-by: David Hildenbrand <david@...hat.com>

-- 
Cheers,

David / dhildenb