linux-kernel - Re: [PATCH 2/2] hwmon: (ina780) Add driver for TI INA780

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7f621788-372b-4a0b-a126-4c2d1d9a926c@alliedtelesis.co.nz>
Date: Wed, 6 Aug 2025 03:41:41 +0000
From: Chris Packham <Chris.Packham@...iedtelesis.co.nz>
To: Guenter Roeck <linux@...ck-us.net>, "jdelvare@...e.com"
	<jdelvare@...e.com>, "robh@...nel.org" <robh@...nel.org>,
	"krzk+dt@...nel.org" <krzk+dt@...nel.org>, "conor+dt@...nel.org"
	<conor+dt@...nel.org>
CC: "linux-hwmon@...r.kernel.org" <linux-hwmon@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] hwmon: (ina780) Add driver for TI INA780

Hi Guenter,

On 06/08/2025 15:14, Guenter Roeck wrote:
> On 8/5/25 17:51, Chris Packham wrote:
>> Add support for the TI INA780 Digital Power Monitor.
>>
>> Signed-off-by: Chris Packham <chris.packham@...iedtelesis.co.nz>
>
> Looking at the registers, the chip seems to be almost identical to 
> INA237/238.
> Why a new driver ?

Yes I'd noticed the same thing as I went along. The INA780 has the 
ezshunt thing (not sure if that's the same as the internal shunt on the 
INA260) which means that a lot of the places where things are calculated 
by the shunt resistor value aren't applicable and there's one less 
voltage sensor. I did consider adding it to the ina2xx.c but it seemed 
different enough to those chips to warrant a separate driver.

I think I can kind of squint and see how I might fold the ina780 support 
into the ina238 driver although that may make things a bit messier. If 
that's the direction you'd like to head I can give it a go.