linux-kernel - Re: [PATCH 2/2] EDAC/amd64: Incorporate DRAM Address in EDAC message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250806211524.GFaJPF7Bk2dooZOVzc@fat_crate.local>
Date: Wed, 6 Aug 2025 23:15:24 +0200
From: Borislav Petkov <bp@...en8.de>
To: "Naik, Avadhut" <avadnaik@....com>
Cc: Yazen Ghannam <yazen.ghannam@....com>,
	Avadhut Naik <avadhut.naik@....com>, linux-edac@...r.kernel.org,
	john.allen@....com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] EDAC/amd64: Incorporate DRAM Address in EDAC message

On Wed, Aug 06, 2025 at 04:08:07PM -0500, Naik, Avadhut wrote:
> >> +			sprintf(s, "Cs: 0x%x Bank Grp: 0x%x Bank Addr: 0x%x"
> >> +					   " Row: 0x%x Column: 0x%x"
> >> +					   " RankMul: 0x%x SubChannel: 0x%x",
> > 
> > There's a checkpatch warning here about splitting user-visible strings.
> > 
> > Why not use scnprintf() or the like?
> > 
> Had noticed the checkpatch warning initially.
> IIRC, it was for splitting the quoted string across multiple lines.
> Can use scnprintf here. But wont the warning still prevail?

Just do one long line. The idea is to be able to grep the code when you see
the string issued in dmesg.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette