linux-kernel - linux-6.16/fs/netfs/read_collect.c:575: Pointless test ?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID:
 <AS8PR02MB10217782094C222870CC5A7A29C2DA@AS8PR02MB10217.eurprd02.prod.outlook.com>
Date: Wed, 6 Aug 2025 06:03:09 +0000
From: David Binderman <dcb314@...mail.com>
To: "dhowells@...hat.com" <dhowells@...hat.com>, "pc@...guebit.org"
	<pc@...guebit.org>, "netfs@...ts.linux.dev" <netfs@...ts.linux.dev>,
	"linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>, Linux Kernel
 Mailing List <linux-kernel@...r.kernel.org>
Subject: linux-6.16/fs/netfs/read_collect.c:575: Pointless test ?

Hello there,

Static analyser cppcheck says:

linux-6.16/fs/netfs/read_collect.c:575:28: warning: Identical inner 'if' condition is always true. [identicalInnerCondition]

Source code is

    if (transferred_or_error > 0) {
        subreq->error = 0;
        if (transferred_or_error > 0) {

Suggest remove second test.

Regards

David Binderman