linux-kernel - Re: [PATCH v6 2/2] media: i2c: add ov2735 image sensor driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <PN3P287MB35196F4C68AF1E0B69EED511FF2DA@PN3P287MB3519.INDP287.PROD.OUTLOOK.COM>
Date: Wed, 6 Aug 2025 06:09:30 +0000
From: Hardevsinh Palaniya <hardevsinh.palaniya@...iconsignals.io>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
CC: "sakari.ailus@...ux.intel.com" <sakari.ailus@...ux.intel.com>,
	"laurent.pinchart@...asonboard.com" <laurent.pinchart@...asonboard.com>,
	"kieran.bingham@...asonboard.com" <kieran.bingham@...asonboard.com>, Himanshu
 Bhavani <himanshu.bhavani@...iconsignals.io>, Mauro Carvalho Chehab
	<mchehab@...nel.org>, Rob Herring <robh@...nel.org>, Krzysztof Kozlowski
	<krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Hans Verkuil
	<hverkuil@...all.nl>, Ricardo Ribalda <ribalda@...omium.org>, Hans de Goede
	<hansg@...nel.org>, Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
	André Apitzsch <git@...tzsch.eu>, Arnd Bergmann
	<arnd@...db.de>, Sylvain Petinot <sylvain.petinot@...s.st.com>, Dongcheng Yan
	<dongcheng.yan@...el.com>, Benjamin Mugnier <benjamin.mugnier@...s.st.com>,
	Jingjing Xiong <jingjing.xiong@...el.com>, Matthias Fend
	<matthias.fend@...end.at>, Heimir Thor Sverrisson
	<heimir.sverrisson@...il.com>, "linux-media@...r.kernel.org"
	<linux-media@...r.kernel.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v6 2/2] media: i2c: add ov2735 image sensor driver

> On Thu, Jul 31, 2025 at 11:39:58AM +0530, Hardevsinh Palaniya wrote:
> > Add a v4l2 subdevice driver for the Omnivision OV2735 sensor.
> >
> > The Omnivision OV2735 is a 1/2.7-Inch CMOS image sensor with an
> > active array size of 1920 x 1080.
> >
> > The following features are supported:
> > - Manual exposure an gain control support
> > - vblank/hblank control support
> > - Test pattern support control
> > - Supported resolution: 1920 x 1080 @ 30fps (SGRBG10)
> 
> ...
> 
> > +#define OV2735_REG_LONG_EXPOSURE             OV2735_PAGE_REG16(0x01, 0x03)
> > +#define      OV2735_EXPOSURE_MIN                     4
> > +#define      OV2735_EXPOSURE_STEP                    1
> > +
> > +#define OV2735_REG_ANALOG_GAIN                  OV2735_PAGE_REG8(0x01, 0x24)
> > +#define      OV2735_ANALOG_GAIN_MIN                  0x10
> > +#define      OV2735_ANALOG_GAIN_MAX                  0xff
> > +#define      OV2735_ANALOG_GAIN_STEP                 1
> > +#define      OV2735_ANALOG_GAIN_DEFAULT              0x10
> 
> I dunno if the TAB after #define is something being required here, to me sounds
> like a misplacement.
 
When I applied the patch, I didn’t see those tabs either.
I'm not sure how they appeared in the patch, but I will correct them.
 
> > +static int ov2735_page_access(struct ov2735 *ov2735, u32 reg, int *err)
> > +{
> > +     u8 page = reg >> CCI_REG_PRIVATE_SHIFT;
> > +     int ret = 0;
> > +
> > +     if (err && *err)
> > +             return *err;
> 
> > +     mutex_lock(&ov2735->page_lock);
> 
> Since you have cleanup.h, why not use guard() here?

will update

Best Regards,
Hardev