[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20250806-greybus-string-choices-v1-1-3e1c91048b62@gmail.com>
Date: Wed, 06 Aug 2025 14:27:11 +0800
From: Nai-Chen Cheng <bleach1827@...il.com>
To: Johan Hovold <johan@...nel.org>, Alex Elder <elder@...nel.org>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: greybus-dev@...ts.linaro.org, linux-kernel@...r.kernel.org,
Shuah Khan <skhan@...uxfoundation.org>,
linux-kernel-mentees@...ts.linux.dev, Nai-Chen Cheng <bleach1827@...il.com>
Subject: [PATCH] greybus: svc: use string choice helpers instead of ternary
operator
Replace ternary operator with str_enabled_disabled() helper to improve
code readability and consistency.
Generated using Coccinelle semantic patch.
Signed-off-by: Nai-Chen Cheng <bleach1827@...il.com>
---
drivers/greybus/svc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/greybus/svc.c b/drivers/greybus/svc.c
index 4256467fcd35..35ea7147dca6 100644
--- a/drivers/greybus/svc.c
+++ b/drivers/greybus/svc.c
@@ -10,6 +10,7 @@
#include <linux/kstrtox.h>
#include <linux/workqueue.h>
#include <linux/greybus.h>
+#include <linux/string_choices.h>
#define SVC_INTF_EJECT_TIMEOUT 9000
#define SVC_INTF_ACTIVATE_TIMEOUT 6000
@@ -73,7 +74,7 @@ static ssize_t watchdog_show(struct device *dev, struct device_attribute *attr,
struct gb_svc *svc = to_gb_svc(dev);
return sprintf(buf, "%s\n",
- gb_svc_watchdog_enabled(svc) ? "enabled" : "disabled");
+ str_enabled_disabled(gb_svc_watchdog_enabled(svc)));
}
static ssize_t watchdog_store(struct device *dev,
---
base-commit: 7881cd6886a89eda848192d3f5759ce08672e084
change-id: 20250806-greybus-string-choices-e6d53d2382a6
Best regards,
--
Nai-Chen Cheng <bleach1827@...il.com>
Powered by blists - more mailing lists