linux-kernel - Re: [PATCH] drm/mediatek: fix device leaks at bind

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bc3eb7e9118143214760ec240bcd339ee38adf68.camel@mediatek.com>
Date: Wed, 6 Aug 2025 07:13:45 +0000
From: CK Hu (胡俊光) <ck.hu@...iatek.com>
To: "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
	"chunkuang.hu@...nel.org" <chunkuang.hu@...nel.org>, "johan@...nel.org"
	<johan@...nel.org>
CC: Nancy Lin (林欣螢) <Nancy.Lin@...iatek.com>,
	"simona@...ll.ch" <simona@...ll.ch>, "dri-devel@...ts.freedesktop.org"
	<dri-devel@...ts.freedesktop.org>, AngeloGioacchino Del Regno
	<angelogioacchino.delregno@...labora.com>, "airlied@...il.com"
	<airlied@...il.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "matthias.bgg@...il.com"
	<matthias.bgg@...il.com>, "linux-mediatek@...ts.infradead.org"
	<linux-mediatek@...ts.infradead.org>, "stable@...r.kernel.org"
	<stable@...r.kernel.org>
Subject: Re: [PATCH] drm/mediatek: fix device leaks at bind

On Tue, 2025-07-22 at 11:27 +0200, Johan Hovold wrote:
> External email : Please do not click links or open attachments until you have verified the sender or the content.
> 
> 
> Make sure to drop the references to the sibling platform devices and
> their child drm devices taken by of_find_device_by_node() and
> device_find_child() when initialising the driver data during bind().

Reviewed-by: CK Hu <ck.hu@...iatek.com>

> 
> Fixes: 1ef7ed48356c ("drm/mediatek: Modify mediatek-drm for mt8195 multi mmsys support")
> Cc: stable@...r.kernel.org      # 6.4
> Cc: Nancy.Lin <nancy.lin@...iatek.com>
> Signed-off-by: Johan Hovold <johan@...nel.org>
> ---
>  drivers/gpu/drm/mediatek/mtk_drm_drv.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> index 7c0c12dde488..33b83576af7e 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> @@ -395,10 +395,12 @@ static bool mtk_drm_get_all_drm_priv(struct device *dev)
>                         continue;
> 
>                 drm_dev = device_find_child(&pdev->dev, NULL, mtk_drm_match);
> +               put_device(&pdev->dev);
>                 if (!drm_dev)
>                         continue;
> 
>                 temp_drm_priv = dev_get_drvdata(drm_dev);
> +               put_device(drm_dev);
>                 if (!temp_drm_priv)
>                         continue;
> 
> --
> 2.49.1
>