[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <od4kpr5k22jruqa3gk4mgbcte73wlhmew7nep2xumo2j7iofxo@nd434suk47p5>
Date: Wed, 6 Aug 2025 10:32:44 +0300
From: Laurentiu Palcu <laurentiu.palcu@....nxp.com>
To: Liao Yuanhong <liaoyuanhong@...o.com>
Cc: Lucas Stach <l.stach@...gutronix.de>,
Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>,
Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>,
Simona Vetter <simona@...ll.ch>, Shawn Guo <shawnguo@...nel.org>,
Sascha Hauer <s.hauer@...gutronix.de>, Pengutronix Kernel Team <kernel@...gutronix.de>,
Fabio Estevam <festevam@...il.com>,
"open list:NXP i.MX 8MQ DCSS DRIVER" <dri-devel@...ts.freedesktop.org>,
"open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" <imx@...ts.linux.dev>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" <linux-arm-kernel@...ts.infradead.org>, open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/4] drm/imx: Remove goto label that are only used once
Hi Liao,
On Tue, Aug 05, 2025 at 03:46:18PM +0800, Liao Yuanhong wrote:
> Remove unnecessary goto labels to improve code readability.
>
> Signed-off-by: Liao Yuanhong <liaoyuanhong@...o.com>
> ---
> drivers/gpu/drm/imx/dcss/dcss-drv.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/imx/dcss/dcss-drv.c b/drivers/gpu/drm/imx/dcss/dcss-drv.c
> index 19b027cc1dc4..3df060a2f6bf 100644
> --- a/drivers/gpu/drm/imx/dcss/dcss-drv.c
> +++ b/drivers/gpu/drm/imx/dcss/dcss-drv.c
> @@ -65,15 +65,11 @@ static int dcss_drv_platform_probe(struct platform_device *pdev)
> if (IS_ERR(mdrv->kms)) {
> err = PTR_ERR(mdrv->kms);
> dev_err_probe(dev, err, "Failed to initialize KMS\n");
> - goto dcss_shutoff;
> + dcss_dev_destroy(mdrv->dcss);
> + return err;
I suppose you can now get rid of 'err' variable and 'return
dev_err_probe()' directly.
Thanks,
Laurentiu
> }
>
> return 0;
> -
> -dcss_shutoff:
> - dcss_dev_destroy(mdrv->dcss);
> -
> - return err;
> }
>
> static void dcss_drv_platform_remove(struct platform_device *pdev)
> --
> 2.34.1
>
Powered by blists - more mailing lists