linux-kernel - Re: [PATCH v3 5/6] drm/bridge: imx: add driver for HDMI TX Parallel Audio Interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54095f77-89d1-4d91-ada3-e3c04ac49967@nxp.com>
Date: Wed, 6 Aug 2025 15:54:37 +0800
From: Liu Ying <victor.liu@....com>
To: Shengjiu Wang <shengjiu.wang@...il.com>
Cc: Shengjiu Wang <shengjiu.wang@....com>, andrzej.hajda@...el.com,
 neil.armstrong@...aro.org, rfoss@...nel.org,
 Laurent.pinchart@...asonboard.com, jonas@...boo.se,
 jernej.skrabec@...il.com, maarten.lankhorst@...ux.intel.com,
 mripard@...nel.org, tzimmermann@...e.de, airlied@...il.com, simona@...ll.ch,
 lumag@...nel.org, dianders@...omium.org, cristian.ciocaltea@...labora.com,
 luca.ceresoli@...tlin.com, dri-devel@...ts.freedesktop.org,
 linux-kernel@...r.kernel.org, shawnguo@...nel.org, s.hauer@...gutronix.de,
 kernel@...gutronix.de, festevam@...il.com, imx@...ts.linux.dev,
 linux-arm-kernel@...ts.infradead.org, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, p.zabel@...gutronix.de, devicetree@...r.kernel.org,
 l.stach@...gutronix.de, perex@...ex.cz, tiwai@...e.com,
 linux-sound@...r.kernel.org
Subject: Re: [PATCH v3 5/6] drm/bridge: imx: add driver for HDMI TX Parallel
 Audio Interface

On 08/06/2025, Shengjiu Wang wrote:
> On Tue, Aug 5, 2025 at 4:55 PM Liu Ying <victor.liu@....com> wrote:
>>
>> On 08/04/2025, Shengjiu Wang wrote:

[...]

>>> +#define HTX_PAI_STAT                 0x0c
>>> +#define HTX_PAI_IRQ_NOMASK           0x10
>>> +#define HTX_PAI_IRQ_MASKED           0x14
>>> +#define HTX_PAI_IRQ_MASK             0x18
>>
>> The above 4 registers are not pratically used.  Drop.
> 
> They are used by regmap to make a full definition.

Yes, but they are not pratically used for interrupt support.
Once you add interrupt support in this driver, you may add these registers.

[...]

>>> +             /* PCM choose 24bit*/
>>> +             val = FIELD_PREP(D_SEL, width - 24);
>>
>> Why 'width - 24'?  Can it be expressed by a helper or macro?
> 
>                 /*
>                  * The allowed width are 24bit and 32bit, as they are
> supported by
>                  * aud2htx module.
>                  * for 24bit, D_SEL = 0, select all the bits.
>                  * for 32bit, D_SEL = 8, select the MSB.
>                  */
> will add such comments.

Fine for me(Not an audio guy though).

-- 
Regards,
Liu Ying