linux-kernel - Re: [PATCH] drivers/soc/aspeed: Add AST27XX SoC ID support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <182db4f2848dc7b8c110d45bb606e6219983c237.camel@codeconstruct.com.au>
Date: Wed, 06 Aug 2025 10:45:25 +0930
From: Andrew Jeffery <andrew@...econstruct.com.au>
To: Ryan Chen <ryan_chen@...eedtech.com>, Joel Stanley <joel@....id.au>, 
	linux-arm-kernel@...ts.infradead.org, linux-aspeed@...ts.ozlabs.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers/soc/aspeed: Add AST27XX SoC ID support

Hi Ryan,

Regarding the patch subject, can you please follow the patterns
established by other commits under drivers/soc ?

Separately, can we concentrate efforts on trying to get the platform
definition bits upstream for the AST2700? Arnd's recent newsoc PR adds
several new SoCs (as the tag name suggests), which is a helpful
reference:

https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git/log/?h=soc-newsoc-6.17

Cheers,

Andrew

On Tue, 2025-08-05 at 14:39 +0800, Ryan Chen wrote:
> Extend the ASPEED SoC info driver to support AST27XX silicon IDs.
> 
> Signed-off-by: Ryan Chen <ryan_chen@...eedtech.com>
> ---
>  drivers/soc/aspeed/aspeed-socinfo.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/soc/aspeed/aspeed-socinfo.c b/drivers/soc/aspeed/aspeed-socinfo.c
> index 3f759121dc00..67e9ac3d08ec 100644
> --- a/drivers/soc/aspeed/aspeed-socinfo.c
> +++ b/drivers/soc/aspeed/aspeed-socinfo.c
> @@ -27,6 +27,10 @@ static struct {
>         { "AST2620", 0x05010203 },
>         { "AST2605", 0x05030103 },
>         { "AST2625", 0x05030403 },
> +       /* AST2700 */
> +       { "AST2750", 0x06000003 },
> +       { "AST2700", 0x06000103 },
> +       { "AST2720", 0x06000203 },
>  };
>  
>  static const char *siliconid_to_name(u32 siliconid)