linux-kernel - [PATCH v1] vhost: fix missing descriptor reclaim on copy_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20250806114620.2696386-1-tcs_kernel@tencent.com>
Date: Wed,  6 Aug 2025 19:46:20 +0800
From: bsdhenrymartin@...il.com
To: huntazhang@...cent.com,
	jitxie@...cent.com,
	landonsun@...cent.com,
	mst@...hat.com,
	jasowang@...hat.com
Cc: eperezma@...hat.com,
	kvm@...r.kernel.org,
	virtualization@...ts.linux.dev,
	netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	bsdhenrymartin@...il.com,
	Henry Martin <bsdhenryma@...cent.com>,
	TCS Robot <tcs_robot@...cent.com>
Subject: [PATCH v1] vhost: fix missing descriptor reclaim on copy_to_iter failure

From: Henry Martin <bsdhenryma@...cent.com>

If copy_to_iter(&hdr, sizeof(hdr), &fixup) fails, the descriptor is not
reclaimed via vhost_discard_vq_desc(), leading to potential resource
leaks.

Fix it by explicitly calling vhost_discard_vq_desc() on failure.

Fixes: 4c5a84421c7d ("vhost: cleanup iterator update logic")
Reported-by: TCS Robot <tcs_robot@...cent.com>
Signed-off-by: Henry Martin <bsdhenryma@...cent.com>
---
 drivers/vhost/net.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c
index 6edac0c1ba9b..7b4be344b8af 100644
--- a/drivers/vhost/net.c
+++ b/drivers/vhost/net.c
@@ -1238,6 +1238,7 @@ static void handle_rx(struct vhost_net *net)
 					 &fixup) != sizeof(hdr)) {
 				vq_err(vq, "Unable to write vnet_hdr "
 				       "at addr %p\n", vq->iov->iov_base);
+				vhost_discard_vq_desc(vq, headcount);
 				goto out;
 			}
 		} else {
-- 
2.41.3