linux-kernel - Re: [PATCH] soc: qcom: mdt_loader: Deal with zero e

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3qaicrc3wkmsampq6f6hjmuiwbary6d5l7vrdrvjprzsbb4lbq@4dx66ch6wdj5>
Date: Tue, 5 Aug 2025 18:51:59 -0700
From: Bjorn Andersson <andersson@...nel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
Cc: Neil Armstrong <neil.armstrong@...aro.org>, 
	Bjorn Andersson <bjorn.andersson@....qualcomm.com>, Konrad Dybcio <konradybcio@...nel.org>, 
	linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org, Val Packett <val@...kett.cool>
Subject: Re: [PATCH] soc: qcom: mdt_loader: Deal with zero e_shentsize

On Thu, Jul 31, 2025 at 11:23:25PM +0300, Dmitry Baryshkov wrote:
> On Thu, Jul 31, 2025 at 04:58:09PM +0200, Neil Armstrong wrote:
> > On 30/07/2025 22:51, Bjorn Andersson wrote:
> > > Firmware that doesn't provide section headers leave both e_shentsize and
> > > e_shnum 0, which obvious isn't compatible with the newly introduced
> > > stricter checks.
> > > 
> > > Make the section-related checks conditional on either of these values
> > > being non-zero.
> > > 
> > Missing:
> > Fixes: 9f35ab0e53cc ("soc: qcom: mdt_loader: Fix error return values in mdt_header_valid()")
> > 
> > Or it won't apply on stable kernels
> 
> Then it should also be:
> 
> Cc: stable@...r.kernel.org
> 

Given that the fixed commit is Cc: stable, it makes sense to include
both.

Thanks,
Bjorn

> 
> -- 
> With best wishes
> Dmitry