[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <6e5b5c47-a97c-4757-ac0d-361c91fd5819@amd.com>
Date: Wed, 6 Aug 2025 14:32:28 +0200
From: Christian König <christian.koenig@....com>
To: cryolitia@...ontech.com, Alex Deucher <alexander.deucher@....com>,
David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>
Cc: amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
linux-kernel@...r.kernel.org, wangyuli@...ontech.com, zhanjun@...ontech.com,
guanwentao@...ontech.com
Subject: Re: [PATCH] drm/amdgpu: fix incorrect comment format
On 06.08.25 05:34, Cryolitia PukNgae via B4 Relay wrote:
> From: Cryolitia PukNgae <cryolitia@...ontech.com>
>
> Comments should not have a leading plus sign.
Good catch, potentially a left over from a merge conflict or similar.
>
> Signed-off-by: Cryolitia PukNgae <cryolitia@...ontech.com>
Acked-by: Christian König <christian.koenig@....com>
> ---
> drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c b/drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c
> index d5002ff931d841994ca2c70cdf5b989f5b3c59d6..860bc5cb03c81b5346743b5fb46a7dcbe5a201a4 100644
> --- a/drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c
> +++ b/drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c
> @@ -151,9 +151,9 @@ static void nbio_v7_4_sdma_doorbell_range(struct amdgpu_device *adev, int instan
> * BIF_SDMA0_DOORBELL_RANGE: 0x3bc0
> * BIF_SDMA1_DOORBELL_RANGE: 0x3bc4
> * BIF_SDMA2_DOORBELL_RANGE: 0x3bd8
> -+ * BIF_SDMA4_DOORBELL_RANGE:
> -+ * ARCTURUS: 0x3be0
> -+ * ALDEBARAN: 0x3be4
> + * BIF_SDMA4_DOORBELL_RANGE:
> + * ARCTURUS: 0x3be0
> + * ALDEBARAN: 0x3be4
> */
> if (adev->asic_type == CHIP_ALDEBARAN && instance == 4)
> reg = instance + 0x4 + 0x1 +
>
> ---
> base-commit: 6bcdbd62bd56e6d7383f9e06d9d148935b3c9b73
> change-id: 20250806-amdgpu_typo-80869b122c36
>
> Best regards,
Powered by blists - more mailing lists