linux-kernel - Re: [PATCH] cdx: don't select CONFIG_GENERIC_MSI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ffd07f38-670e-45f1-96df-60b2d38ff185@linaro.org>
Date: Wed, 6 Aug 2025 14:42:33 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Arnd Bergmann <arnd@...nel.org>, Nipun Gupta <nipun.gupta@....com>,
 Nikhil Agarwal <nikhil.agarwal@....com>
Cc: Thomas Gleixner <tglx@...utronix.de>, Marc Zyngier <maz@...nel.org>,
 Arnd Bergmann <arnd@...db.de>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Thomas Weißschuu <linux@...ssschuh.net>,
 Qiu-ji Chen <chenqiuji666@...il.com>, Peter Zijlstra <peterz@...radead.org>,
 "Rob Herring (Arm)" <robh@...nel.org>, Robin Murphy <robin.murphy@....com>,
 Abhijit Gangurde <abhijit.gangurde@....com>,
 Nathan Chancellor <nathan@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cdx: don't select CONFIG_GENERIC_MSI_IRQ

On 05/08/2025 18:10, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> x86 does not use CONFIG_GENERIC_MSI_IRQ, and trying to enable it anyway
> results in a build failure:
> 
> In file included from include/linux/ssb/ssb.h:10,
>                  from drivers/ssb/pcihost_wrapper.c:18:
> include/linux/gpio/driver.h:41:33: error: field 'msiinfo' has incomplete type
>    41 |         msi_alloc_info_t        msiinfo;
>       |                                 ^~~~~~~
> In file included from include/linux/kvm_host.h:19,
>                  from arch/x86/events/intel/core.c:17:
> include/linux/msi.h:528:33: error: field 'alloc_info' has incomplete type
>   528 |         msi_alloc_info_t        alloc_info;
> 
> Change the driver to actually build without this symbol and remove the
> incorrect 'select' statements.
> 

Maybe also original reported-by credits?
https://lore.kernel.org/all/20250717091053.129175-2-krzysztof.kozlowski@linaro.org/

And cc-stable and fixes.

I started working on this and had similar fix, but then I got impression
the CDX people will fix that:

https://lore.kernel.org/all/BL1PR12MB5333449243C7FE258728C8E39D5EA@BL1PR12MB5333.namprd12.prod.outlook.com/

so I stopped working.

Shall CDX maintainers entry be changed to Odd Fixes?

Best regards,
Krzysztof