linux-kernel - Re: [PATCH v2] ksmbd: add kcov remote coverage support via ksmbd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <751a8c65-282f-4ed7-b09c-9f115f526134@kzalloc.com>
Date: Wed, 6 Aug 2025 23:12:28 +0900
From: Yunseong Kim <ysk@...lloc.com>
To: Stefan Metzmacher <metze@...ba.org>, Namjae Jeon <linkinjeon@...nel.org>,
 Steve French <smfrench@...il.com>
Cc: Paulo Alcantara <pc@...guebit.org>,
 Sergey Senozhatsky <senozhatsky@...omium.org>, Tom Talpey <tom@...pey.com>,
 linux-cifs@...r.kernel.org, syzkaller@...glegroups.com,
 linux-kernel@...r.kernel.org, notselwyn@...ing.tech
Subject: Re: [PATCH v2] ksmbd: add kcov remote coverage support via ksmbd_conn

Hi Stefan,

On 8/6/25 10:57 오후, Stefan Metzmacher wrote:
> Hi Yunseong,
> 
>> diff --git a/fs/smb/server/connection.c b/fs/smb/server/connection.c
>> index 3f04a2977ba8..21352f37384f 100644
>> --- a/fs/smb/server/connection.c
>> +++ b/fs/smb/server/connection.c
>> @@ -93,6 +93,9 @@ struct ksmbd_conn *ksmbd_conn_alloc(void)
>>       down_write(&conn_list_lock);
>>       list_add(&conn->conns_list, &conn_list);
>>       up_write(&conn_list_lock);
>> +
>> +    ksmbd_conn_set_kcov_handle(conn, kcov_common_handle());
>> +
>>       return conn;
>>   }
> 
> ...
> 
>> +
>> +static inline void ksmbd_conn_set_kcov_handle(struct ksmbd_conn *conn,
>> +                       const u64 kcov_handle)
>> +{
>> +#ifdef CONFIG_KCOV
>> +    conn->kcov_handle = kcov_common_handle();
>> +#endif
>> +}
> 
> The caller passes kcov_common_handle() as argument, which is not used
> but kcov_common_handle() is called again...
> 
> metze

You're right — this is definitely wrong. I'll fix it and send an updated
version. Thanks!


Best regards,
Yunseong Kim