linux-kernel - Re: [PATCH] maple_tree: Remove redundant __GFP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ovpvaeadvegfuhzl7a3ttnmwok7qwn5rs5o3ohwww3byfqdbkm@jky5zrvvj7lb>
Date: Wed, 6 Aug 2025 10:16:13 -0400
From: "Liam R. Howlett" <Liam.Howlett@...cle.com>
To: Qianfeng Rong <rongqianfeng@...o.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>, linux-kernel@...r.kernel.org,
        maple-tree@...ts.infradead.org, linux-mm@...ck.org,
        willy@...radead.org
Subject: Re: [PATCH] maple_tree: Remove redundant __GFP_NOWARN

* Qianfeng Rong <rongqianfeng@...o.com> [250804 08:57]:
> Commit 16f5dfbc851b ("gfp: include __GFP_NOWARN in GFP_NOWAIT")
> made GFP_NOWAIT implicitly include __GFP_NOWARN.
> 
> Therefore, explicit __GFP_NOWARN combined with GFP_NOWAIT
> (e.g., `GFP_NOWAIT | __GFP_NOWARN`) is now redundant. Let's clean
> up these redundant flags across subsystems.
> 
> No functional changes.
> 
> Signed-off-by: Qianfeng Rong <rongqianfeng@...o.com>

Reviewed-by: Liam R. Howlett <Liam.Howlett@...cle.com>

> ---
>  lib/maple_tree.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/maple_tree.c b/lib/maple_tree.c
> index b4ee2d29d7a9..38fb68c08291 100644
> --- a/lib/maple_tree.c
> +++ b/lib/maple_tree.c
> @@ -1344,11 +1344,11 @@ static void mas_node_count_gfp(struct ma_state *mas, int count, gfp_t gfp)
>   * @mas: The maple state
>   * @count: The number of nodes needed
>   *
> - * Note: Uses GFP_NOWAIT | __GFP_NOWARN for gfp flags.
> + * Note: Uses GFP_NOWAIT for gfp flags.
>   */
>  static void mas_node_count(struct ma_state *mas, int count)
>  {
> -	return mas_node_count_gfp(mas, count, GFP_NOWAIT | __GFP_NOWARN);
> +	return mas_node_count_gfp(mas, count, GFP_NOWAIT);
>  }
>  
>  /*
> -- 
> 2.34.1
>