linux-kernel - Re: [PATCH] drm/bridge: analogix_dp: Fix a NULL vs IS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250806161836.3ca0eef4@booty>
Date: Wed, 6 Aug 2025 16:18:36 +0200
From: Luca Ceresoli <luca.ceresoli@...tlin.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Marek Szyprowski <m.szyprowski@...sung.com>, Andrzej Hajda
 <andrzej.hajda@...el.com>, Neil Armstrong <neil.armstrong@...aro.org>,
 Robert Foss <rfoss@...nel.org>, Laurent Pinchart
 <Laurent.pinchart@...asonboard.com>, Jonas Karlman <jonas@...boo.se>,
 Jernej Skrabec <jernej.skrabec@...il.com>, Maarten Lankhorst
 <maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>,
 Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>,
 Simona Vetter <simona@...ll.ch>, Dmitry Baryshkov
 <dmitry.baryshkov@....qualcomm.com>, Douglas Anderson
 <dianders@...omium.org>, Damon Ding <damon.ding@...k-chips.com>,
 dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
 kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] drm/bridge: analogix_dp: Fix a NULL vs IS_ERR() check
 in probe()

Hello Dan,

On Wed, 6 Aug 2025 14:45:36 +0300
Dan Carpenter <dan.carpenter@...aro.org> wrote:

> The devm_drm_bridge_alloc() function doesn't return NULL pointers, it
> returns error pointers.  Update the error checking to match.
> 
> Fixes: 48f05c3b4b70 ("drm/bridge: analogix_dp: Use devm_drm_bridge_alloc() API")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>

Thanks! You fix is correct, but an equivalent patch has been sent a few
hours ago, so I guess that one should be applied:
https://lore.kernel.org/all/20250806095224.527938-1-victor.liu@nxp.com/

Best regards,
Luca

-- 
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com