linux-kernel - Re: [PATCH 1/3] phy: tegra: xusb: fix device and OF node leak at probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <92042af6-e498-460e-be88-8c1f1b4d74f9@linaro.org>
Date: Wed, 6 Aug 2025 16:35:09 +0200
From: neil.armstrong@...aro.org
To: Johan Hovold <johan@...nel.org>, Vinod Koul <vkoul@...nel.org>
Cc: JC Kuo <jckuo@...dia.com>, Kishon Vijay Abraham I <kishon@...nel.org>,
 Thierry Reding <thierry.reding@...il.com>,
 Jonathan Hunter <jonathanh@...dia.com>, linux-phy@...ts.infradead.org,
 linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org,
 stable@...r.kernel.org
Subject: Re: [PATCH 1/3] phy: tegra: xusb: fix device and OF node leak at
 probe

On 24/07/2025 15:12, Johan Hovold wrote:
> Make sure to drop the references taken to the PMC OF node and device by
> of_parse_phandle() and of_find_device_by_node() during probe.
> 
> Note the holding a reference to the PMC device does not prevent the
> PMC regmap from going away (e.g. if the PMC driver is unbound) so there
> is no need to keep the reference.
> 
> Fixes: 2d1021487273 ("phy: tegra: xusb: Add wake/sleepwalk for Tegra210")
> Cc: stable@...r.kernel.org	# 5.14
> Cc: JC Kuo <jckuo@...dia.com>
> Signed-off-by: Johan Hovold <johan@...nel.org>
> ---
>   drivers/phy/tegra/xusb-tegra210.c | 6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)
> 

<snip>


Reviewed-by: Neil Armstrong <neil.armstrong@...aro.org>