linux-kernel - Re: [PATCH 1/2] iio: adc: ad799x: add reference voltage capability to chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6397c502-26b2-4fdc-825c-2f666c43ea95@baylibre.com>
Date: Wed, 6 Aug 2025 10:36:35 -0500
From: David Lechner <dlechner@...libre.com>
To: Jonathan Cameron <Jonathan.Cameron@...wei.com>,
 Stefano Manni <stefano.manni@...il.com>
Cc: lars@...afoo.de, Michael.Hennerich@...log.com, jic23@...nel.org,
 nuno.sa@...log.com, andy@...nel.org, linux-iio@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] iio: adc: ad799x: add reference voltage capability to
 chip_info

On 8/6/25 9:58 AM, Jonathan Cameron wrote:
> On Wed,  6 Aug 2025 11:01:57 +0200
> Stefano Manni <stefano.manni@...il.com> wrote:
> 

...

>> +	else {
> 
> 	} else {
> 
>> +		st->vref = NULL;
>> +		dev_dbg(&client->dev, "Supplied reference not supported\n");
>> +	}
>>  
>>  	st->client = client;
>>  
> 

I would just completely drop the else. st->vref is already
NULL since st is zeroed at allocation and the message is no
longer useful. Previously, it warned that the devicetree
contained a vref-supply when the chip didn't support it.
But now no message is printed in that case and this message
would be printed on all chips that don't have vref-supply
in the devicetree when that case didn't print anything before.