linux-kernel - Re: [PATCH] i3c: remove 'const' from FIFO helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025080720214218750df5@mail.local>
Date: Thu, 7 Aug 2025 22:21:42 +0200
From: Alexandre Belloni <alexandre.belloni@...tlin.com>
To: Wolfram Sang <wsa+renesas@...g-engineering.com>
Cc: linux-renesas-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel test robot <lkp@...el.com>, Frank Li <Frank.Li@....com>,
	Jorge Marques <jorge.marques@...log.com>,
	linux-i3c@...ts.infradead.org
Subject: Re: [PATCH] i3c: remove 'const' from FIFO helpers

On 07/08/2025 06:31:24+0200, Wolfram Sang wrote:
> As buildbot reports, some architectures do not want const pointers.
> 
> Fixes: 733b439375b4 ("i3c: master: Add inline i3c_readl_fifo() and i3c_writel_fifo()")
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202508070438.TZZA3f2S-lkp@intel.com/
> Signed-off-by: Wolfram Sang <wsa+renesas@...g-engineering.com>
> ---
> 
> I still wonder why SPARC discards the const but since nobody seems to be
> commenting on that, I guess the fastest way to get the build error out
> of Linus' tree is to adapt the usage in I3C.
> 

My plan was to let sparc people handle their mess, there is no reason
const should be discarded.

>  drivers/i3c/internals.h | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/i3c/internals.h b/drivers/i3c/internals.h
> index 0d857cc68cc5..2b0b9c3a9131 100644
> --- a/drivers/i3c/internals.h
> +++ b/drivers/i3c/internals.h
> @@ -30,8 +30,7 @@ void i3c_dev_free_ibi_locked(struct i3c_dev_desc *dev);
>   * @buf: Pointer to the data bytes to write
>   * @nbytes: Number of bytes to write
>   */
> -static inline void i3c_writel_fifo(void __iomem *addr, const void *buf,
> -				   int nbytes)
> +static inline void i3c_writel_fifo(void __iomem *addr, void *buf, int nbytes)
>  {
>  	writesl(addr, buf, nbytes / 4);
>  	if (nbytes & 3) {
> @@ -48,8 +47,7 @@ static inline void i3c_writel_fifo(void __iomem *addr, const void *buf,
>   * @buf: Pointer to the buffer to store read bytes
>   * @nbytes: Number of bytes to read
>   */
> -static inline void i3c_readl_fifo(const void __iomem *addr, void *buf,
> -				  int nbytes)
> +static inline void i3c_readl_fifo(void __iomem *addr, void *buf, int nbytes)
>  {
>  	readsl(addr, buf, nbytes / 4);
>  	if (nbytes & 3) {
> -- 
> 2.47.2
> 

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com