linux-kernel - Re: [PATCH 1/2] dt-bindings: hwmon: ti,ina780a: Add INA780 device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aa814850-79ee-4c88-87d8-a3d70036ef2d@alliedtelesis.co.nz>
Date: Thu, 7 Aug 2025 20:46:46 +0000
From: Chris Packham <Chris.Packham@...iedtelesis.co.nz>
To: Krzysztof Kozlowski <krzk@...nel.org>, "jdelvare@...e.com"
	<jdelvare@...e.com>, "linux@...ck-us.net" <linux@...ck-us.net>,
	"robh@...nel.org" <robh@...nel.org>, "krzk+dt@...nel.org"
	<krzk+dt@...nel.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>
CC: "linux-hwmon@...r.kernel.org" <linux-hwmon@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: hwmon: ti,ina780a: Add INA780 device


On 06/08/2025 18:32, Krzysztof Kozlowski wrote:
> On 06/08/2025 02:51, Chris Packham wrote:
>> +
>> +properties:
>> +  compatible:
>> +    enum:
>> +      - ti,ina780a
>> +      - ti,ina780b
>> +
>> +  reg:
>> +    maxItems: 1
>
> This looks a bit incomplete. Where is a supply? No shunt resistor
> choice? No other properties from ina2xx apply?
This chip doesn't need a shunt so pretty much all that is required is 
compatible + reg. Guenter did mention rolling this into the existing 
ina238 driver (and ina2xx binding) so I'm looking at that right now. I'm 
also thinking about dropping the A vs B distinction. They are ordering 
options that do impact the accuracy of the ADC but driver wise they 
behave the same.