linux-kernel - Re: [PATCH v3 1/2] fscontext: do not consume log entries when returning -EMSGSIZE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250807030817.GH222315@ZenIV>
Date: Thu, 7 Aug 2025 04:08:17 +0100
From: Al Viro <viro@...iv.linux.org.uk>
To: Aleksa Sarai <cyphar@...har.com>
Cc: Christian Brauner <brauner@...nel.org>, Jan Kara <jack@...e.cz>,
	David Howells <dhowells@...hat.com>, Shuah Khan <shuah@...nel.org>,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-kselftest@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH v3 1/2] fscontext: do not consume log entries when
 returning -EMSGSIZE

On Thu, Aug 07, 2025 at 12:46:17PM +1000, Aleksa Sarai wrote:

> It felt odd to use "return ret;" at the start and switch to "return n;"
> at the end, but feel free to change it when applying.

s/ret/err/ would take care of that, as well as clarifying the intent -
not that "mutex_lock_interruptible() returns 0 or error" hadn't been
the basic common knowledge...

Anyway, that's really nitpicking at this point.