linux-kernel - Re: [PATCH] nvmet: exit debugfs after discovery subsystem exits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3f440533-8feb-49bb-8dde-6ae520b81d39@flourine.local>
Date: Thu, 7 Aug 2025 09:19:22 +0200
From: Daniel Wagner <dwagner@...e.de>
To: Mohamed Khalfella <mkhalfella@...estorage.com>
Cc: Yi Zhang <yi.zhang@...hat.com>, Christoph Hellwig <hch@....de>, 
	Sagi Grimberg <sagi@...mberg.me>, Chaitanya Kulkarni <kch@...dia.com>, 
	Keith Busch <kbusch@...nel.org>, Shinichiro Kawasaki <shinichiro.kawasaki@....com>, 
	Hannes Reinecke <hare@...nel.org>, Maurizio Lombardi <mlombard@...hat.com>, 
	Jens Axboe <axboe@...nel.dk>, Randy Jennings <randyj@...estorage.com>, 
	linux-nvme@...ts.infradead.org, linux-block <linux-block@...r.kernel.org>, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] nvmet: exit debugfs after discovery subsystem exits

On Wed, Aug 06, 2025 at 10:35:07PM -0700, Mohamed Khalfella wrote:
> Commit 528589947c180 ("nvmet: initialize discovery subsys after debugfs
> is initialized") changed nvmet_init() to initialize nvme discovery after
> "nvmet" debugfs directory is initialized. The change broke nvmet_exit()
> because discovery subsystem now depends on debugfs. Debugfs should be
> destroyed after discovery subsystem. Fix nvmet_exit() to do that.
> 
> Reported-by: Yi Zhang <yi.zhang@...hat.com>
> Closes: https://lore.kernel.org/all/CAHj4cs96AfFQpyDKF_MdfJsnOEo=2V7dQgqjFv+k3t7H-=yGhA@mail.gmail.com/
> Fixes: 528589947c180 ("nvmet: initialize discovery subsys after debugfs is initialized")
> Signed-off-by: Mohamed Khalfella <mkhalfella@...estorage.com>

Reviewed-by: Daniel Wagner <dwagner@...e.de>