linux-kernel - Re: [PATCH] mtd: dc21285: fix bytewise memcpy()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87o6srd0sh.fsf@bootlin.com>
Date: Thu, 07 Aug 2025 09:54:38 +0200
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: Arnd Bergmann <arnd@...nel.org>
Cc: Richard Weinberger <richard@....at>,  Vignesh Raghavendra
 <vigneshr@...com>,  Nathan Chancellor <nathan@...nel.org>,  Arnd Bergmann
 <arnd@...db.de>,  David Woodhouse <dwmw2@...radead.org>,  Nick Desaulniers
 <nick.desaulniers+lkml@...il.com>,  Bill Wendling <morbo@...gle.com>,
  Justin Stitt <justinstitt@...gle.com>,  linux-mtd@...ts.infradead.org,
  linux-kernel@...r.kernel.org,  llvm@...ts.linux.dev
Subject: Re: [PATCH] mtd: dc21285: fix bytewise memcpy()

Hello Arnd,

On 07/08/2025 at 09:20:34 +02, Arnd Bergmann <arnd@...nel.org> wrote:

> From: Arnd Bergmann <arnd@...db.de>
>
> The commit that split up the 8/16/32-bit operations in 2004 seems to have
> broken the 8-bit case, as clang-21 now points out:
>
> drivers/mtd/maps/dc21285.c:129:97: error: parameter 'len' set but not used [-Werror,-Wunused-but-set-parameter]
>   129 | static void dc21285_copy_to_8(struct map_info *map, unsigned long to, const void *from, ssize_t len)
>
> Put back the loop that was in linux-2.6.8 and earlier for this case.
>
> Fixes: 67d4878e4e61 ("NOR flash drivers update")
> Cc: David Woodhouse <dwmw2@...radead.org>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Thanks for the patch, I'll take it, but that probably means few to no
people still use it, if broken for more than 20 years...

Cheers,
Miquèl