linux-kernel - Re: [PATCH] usb: dwc3: Ignore late xferNotReady event to prevent halt timeout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250807005558.72hmwuwsjknejhsb@synopsys.com>
Date: Thu, 7 Aug 2025 00:55:59 +0000
From: Thinh Nguyen <Thinh.Nguyen@...opsys.com>
To: Kuen-Han Tsai <khtsai@...gle.com>
CC: Thinh Nguyen <Thinh.Nguyen@...opsys.com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        stable <stable@...nel.org>
Subject: Re: [PATCH] usb: dwc3: Ignore late xferNotReady event to prevent halt
 timeout

On Wed, Aug 06, 2025, Kuen-Han Tsai wrote:
> Hi Thinh,
> 
> Thank you for your review.
> 
> On Wed, Aug 6, 2025 at 7:28 AM Thinh Nguyen <Thinh.Nguyen@...opsys.com> wrote:
> >
> > On Tue, Aug 05, 2025, Kuen-Han Tsai wrote:
> > > During a device-initiated disconnect, the End Transfer command resets
> > > the event filter, allowing a new xferNotReady event to be generated
> > > before the controller is fully halted. Processing this late event
> > > incorrectly triggers a Start Transfer, which prevents the controller
> > > from halting and results in a DSTS.DEVCTLHLT bit polling timeout.
> > >
> > > Ignore the late xferNotReady event if the controller is already in a
> > > disconnected state.
> > >
> > > Fixes: 8f608e8ab628 ("usb: dwc3: gadget: remove unnecessary 'dwc' parameter")
> >
> > The Fixes should target since the beginning of the driver:
> > 72246da40f37 ("usb: Introduce DesignWare USB3 DRD Driver")
> 
> Commit 72246da40f37 doesn't have the dwc->connected member. Should we
> change the Fixes tag to f09ddcfcb8c5 ("usb: dwc3: gadget: Prevent EP
> queuing while stopping transfers")?
> That's the commit where the "dwc->connected = false" logic was moved before
> stopping active transfers within the pullup function.
> 

The Fixes tag should point to where the issue first introduced that this
patch fixes, not necessarily where it can be backported to. You can give
hints to how far back you want the fix to be backported, but may not
have to.

Thanks,
Thinh